fix: add test for empty resourceTypes array

Author: OzTamir

src/tools/network.ts

@@ -65,7 +65,7 @@ export const listNetworkRequests = defineTool({
       )
       .optional()
       .describe(
-        'Filter requests to only return requests of the specified resource types. When omitted, returns all requests.',
+        'Filter requests to only return requests of the specified resource types. When omitted or empty, returns all requests.',
       ),
   },
   handler: async (request, response) => {

tests/McpResponse.test.ts

@@ -4,9 +4,9 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 import assert from 'node:assert';
-import {describe, it} from 'node:test';
+import { describe, it } from 'node:test';
 
-import {getMockRequest, html, withBrowser} from './utils.js';
+import { getMockRequest, html, withBrowser } from './utils.js';
 
 describe('McpResponse', () => {
   it('list pages', async () => {
@@ -120,7 +120,7 @@ Navigation timeout set to 100000 ms`,
   });
   it('adds image when image is attached', async () => {
     await withBrowser(async (response, context) => {
-      response.attachImage({data: 'imageBase64', mimeType: 'image/png'});
+      response.attachImage({ data: 'imageBase64', mimeType: 'image/png' });
       const result = await response.handle('test', context);
       assert.strictEqual(result[0].text, `# test response`);
       assert.equal(result[1].type, 'image');
@@ -273,10 +273,10 @@ describe('McpResponse network request filtering', () => {
       });
       context.getNetworkRequests = () => {
         return [
-          getMockRequest({resourceType: 'script'}),
-          getMockRequest({resourceType: 'image'}),
-          getMockRequest({resourceType: 'stylesheet'}),
-          getMockRequest({resourceType: 'document'}),
+          getMockRequest({ resourceType: 'script' }),
+          getMockRequest({ resourceType: 'image' }),
+          getMockRequest({ resourceType: 'stylesheet' }),
+          getMockRequest({ resourceType: 'document' }),
         ];
       };
       const result = await response.handle('test', context);
@@ -298,9 +298,9 @@ http://example.com GET [pending]`,
       });
       context.getNetworkRequests = () => {
         return [
-          getMockRequest({resourceType: 'script'}),
-          getMockRequest({resourceType: 'image'}),
-          getMockRequest({resourceType: 'stylesheet'}),
+          getMockRequest({ resourceType: 'script' }),
+          getMockRequest({ resourceType: 'image' }),
+          getMockRequest({ resourceType: 'stylesheet' }),
         ];
       };
       const result = await response.handle('test', context);
@@ -321,9 +321,9 @@ http://example.com GET [pending]`,
       });
       context.getNetworkRequests = () => {
         return [
-          getMockRequest({resourceType: 'script'}),
-          getMockRequest({resourceType: 'image'}),
-          getMockRequest({resourceType: 'stylesheet'}),
+          getMockRequest({ resourceType: 'script' }),
+          getMockRequest({ resourceType: 'image' }),
+          getMockRequest({ resourceType: 'stylesheet' }),
         ];
       };
       const result = await response.handle('test', context);
@@ -341,11 +341,40 @@ No requests found.`,
       response.setIncludeNetworkRequests(true);
       context.getNetworkRequests = () => {
         return [
-          getMockRequest({resourceType: 'script'}),
-          getMockRequest({resourceType: 'image'}),
-          getMockRequest({resourceType: 'stylesheet'}),
-          getMockRequest({resourceType: 'document'}),
-          getMockRequest({resourceType: 'font'}),
+          getMockRequest({ resourceType: 'script' }),
+          getMockRequest({ resourceType: 'image' }),
+          getMockRequest({ resourceType: 'stylesheet' }),
+          getMockRequest({ resourceType: 'document' }),
+          getMockRequest({ resourceType: 'font' }),
+        ];
+      };
+      const result = await response.handle('test', context);
+      assert.strictEqual(
+        result[0].text,
+        `# test response
+## Network requests
+Showing 1-5 of 5 (Page 1 of 1).
+http://example.com GET [pending]
+http://example.com GET [pending]
+http://example.com GET [pending]
+http://example.com GET [pending]
+http://example.com GET [pending]`,
+      );
+    });
+  });
+
+  it('shows all requests when empty resourceTypes array is provided', async () => {
+    await withBrowser(async (response, context) => {
+      response.setIncludeNetworkRequests(true, {
+        resourceTypes: [],
+      });
+      context.getNetworkRequests = () => {
+        return [
+          getMockRequest({ resourceType: 'script' }),
+          getMockRequest({ resourceType: 'image' }),
+          getMockRequest({ resourceType: 'stylesheet' }),
+          getMockRequest({ resourceType: 'document' }),
+          getMockRequest({ resourceType: 'font' }),
         ];
       };
       const result = await response.handle('test', context);
@@ -367,7 +396,7 @@ http://example.com GET [pending]`,
 describe('McpResponse network pagination', () => {
   it('returns all requests when pagination is not provided', async () => {
     await withBrowser(async (response, context) => {
-      const requests = Array.from({length: 5}, () => getMockRequest());
+      const requests = Array.from({ length: 5 }, () => getMockRequest());
       context.getNetworkRequests = () => requests;
       response.setIncludeNetworkRequests(true);
       const result = await response.handle('test', context);
@@ -380,13 +409,13 @@ describe('McpResponse network pagination', () => {
 
   it('returns first page by default', async () => {
     await withBrowser(async (response, context) => {
-      const requests = Array.from({length: 30}, (_, idx) =>
-        getMockRequest({method: `GET-${idx}`}),
+      const requests = Array.from({ length: 30 }, (_, idx) =>
+        getMockRequest({ method: `GET-${idx}` }),
       );
       context.getNetworkRequests = () => {
         return requests;
       };
-      response.setIncludeNetworkRequests(true, {pageSize: 10});
+      response.setIncludeNetworkRequests(true, { pageSize: 10 });
       const result = await response.handle('test', context);
       const text = (result[0].text as string).toString();
       assert.ok(text.includes('Showing 1-10 of 30 (Page 1 of 3).'));
@@ -397,8 +426,8 @@ describe('McpResponse network pagination', () => {
 
   it('returns subsequent page when pageIdx provided', async () => {
     await withBrowser(async (response, context) => {
-      const requests = Array.from({length: 25}, (_, idx) =>
-        getMockRequest({method: `GET-${idx}`}),
+      const requests = Array.from({ length: 25 }, (_, idx) =>
+        getMockRequest({ method: `GET-${idx}` }),
       );
       context.getNetworkRequests = () => requests;
       response.setIncludeNetworkRequests(true, {
@@ -415,7 +444,7 @@ describe('McpResponse network pagination', () => {
 
   it('handles invalid page number by showing first page', async () => {
     await withBrowser(async (response, context) => {
-      const requests = Array.from({length: 5}, () => getMockRequest());
+      const requests = Array.from({ length: 5 }, () => getMockRequest());
       context.getNetworkRequests = () => requests;
       response.setIncludeNetworkRequests(true, {
         pageSize: 2,