豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Commit 5a3e0f7

Browse files
committed
test: add coverage for list_pages after selected page is closed
Adds a test that verifies list_pages works correctly when the currently selected page has been closed externally. This exercises the definePageTool → defineTool change that removes the page-scoped requirement from list_pages. Ref #1138
1 parent 7f947ba commit 5a3e0f7

File tree

1 file changed

+22
-4
lines changed

1 file changed

+22
-4
lines changed

tests/tools/pages.test.ts

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,25 @@ describe('pages', () => {
4646
it('list pages', async () => {
4747
await withMcpContext(async (response, context) => {
4848
await listPages().handler(
49-
{params: {}, page: context.getSelectedMcpPage()},
49+
{params: {}},
50+
response,
51+
context,
52+
);
53+
assert.ok(response.includePages);
54+
});
55+
});
56+
it('list pages after selected page is closed', async () => {
57+
await withMcpContext(async (response, context) => {
58+
// Create a second page and select it.
59+
const page2 = await context.newPage();
60+
assert.strictEqual(context.getSelectedMcpPage(), page2);
61+
62+
// Close the selected page via puppeteer (simulating external close).
63+
await page2.pptrPage.close();
64+
65+
// list_pages should still work even though the selected page is gone.
66+
await listPages().handler(
67+
{params: {}},
5068
response,
5169
context,
5270
);
@@ -71,7 +89,7 @@ describe('pages', () => {
7189
categoryExtensions: true,
7290
} as ParsedArguments);
7391
await listPageDef.handler(
74-
{params: {}, page: context.getSelectedMcpPage()},
92+
{params: {}},
7593
response,
7694
context,
7795
);
@@ -117,7 +135,7 @@ describe('pages', () => {
117135
categoryExtensions,
118136
} as ParsedArguments);
119137
await listPageDef.handler(
120-
{params: {}, page: context.getSelectedMcpPage()},
138+
{params: {}},
121139
response,
122140
context,
123141
);
@@ -178,7 +196,7 @@ describe('pages', () => {
178196
categoryExtensions: true,
179197
} as ParsedArguments);
180198
await listPageDef.handler(
181-
{params: {}, page: context.getSelectedMcpPage()},
199+
{params: {}},
182200
response,
183201
context,
184202
);

0 commit comments

Comments
 (0)