fix(memory): prevent unbounded growth of navigations array in PageCollector

Author: flobo3

package-lock.json

@@ -62,7 +62,8 @@ export class PageCollector<T> {
     collector: (item: T) => void,
   ) => ListenerMap<PageEvents>;
   #listeners = new WeakMap<Page, ListenerMap>();
-  #maxNavigationSaved = 3;
+  protected maxNavigationSaved = 3;
+  protected maxItemsPerNavigation = 5000;
 
   /**
    * This maps a Page to a list of navigations with a sub-list
@@ -135,6 +136,9 @@ export class PageCollector<T> {
 
       const navigations = this.storage.get(page) ?? [[]];
       navigations[0].push(withId);
+      if (navigations[0].length > this.maxItemsPerNavigation) {
+        navigations[0].shift(); // Remove oldest item to prevent memory leak
+      }
     });
 
     listeners['framenavigated'] = (frame: Frame) => {
@@ -159,7 +163,7 @@ export class PageCollector<T> {
     }
     // Add the latest navigation first
     navigations.unshift([]);
-    navigations.splice(this.#maxNavigationSaved);
+    navigations.splice(this.maxNavigationSaved);
   }
 
   protected cleanupPageDestroyed(page: Page) {
@@ -183,7 +187,7 @@ export class PageCollector<T> {
     }
 
     const data: T[] = [];
-    for (let index = this.#maxNavigationSaved; index >= 0; index--) {
+    for (let index = this.maxNavigationSaved; index >= 0; index--) {
       if (navigations[index]) {
         data.push(...navigations[index]);
       }
@@ -409,5 +413,6 @@ export class NetworkCollector extends PageCollector<HTTPRequest> {
     } else {
       navigations.unshift([]);
     }
+    navigations.splice(this.maxNavigationSaved);
   }
 }