address comments

Author: wolfib

src/tools/ToolDefinition.ts

@@ -198,7 +198,6 @@ export type Context = Readonly<{
   triggerExtensionAction(id: string): Promise<void>;
   listExtensions(): InstalledExtension[];
   getExtension(id: string): InstalledExtension | undefined;
-  setInPageTools(toolGroup?: ToolGroup<InPageToolDefinition>): void;
   getInPageTools(): ToolGroup<InPageToolDefinition> | undefined;
   getSelectedMcpPage(): McpPage;
   getExtensionServiceWorkers(): ExtensionServiceWorker[];

src/tools/inPage.ts

@@ -66,14 +66,27 @@ export const executeInPageTool = definePageTool({
   schema: {
     toolName: zod.string().describe('The name of the tool to execute'),
     params: zod
-      .record(zod.string(), zod.unknown())
+      .string()
       .optional()
-      .describe('The parameters to pass to the tool'),
+      .describe('The JSON-stringified parameters to pass to the tool'),
   },
   handler: async (request, response, context) => {
     const page = context.getSelectedMcpPage();
     const toolName = request.params.toolName;
-    const params = request.params.params ?? {};
+    let params: Record<string, unknown> = {};
+    if (request.params.params) {
+      try {
+        const parsed = JSON.parse(request.params.params);
+        if (typeof parsed === 'object' && parsed !== null) {
+          params = parsed;
+        } else {
+          throw new Error('Parsed params is not an object');
+        }
+      } catch (e) {
+        const errorMessage = e instanceof Error ? e.message : String(e);
+        throw new Error(`Failed to parse params as JSON: ${errorMessage}`);
+      }
+    }
 
     const toolGroup = context.getInPageTools();
     const tool = toolGroup?.tools.find(t => t.name === toolName);

src/tools/input.ts

@@ -217,6 +217,7 @@ async function fillFormElement(
   }
 }
 
+// here
 export const fill = definePageTool({
   name: 'fill',
   description: `Type text into a input, text area or select an option from a <select> element.`,

tests/tools/inPage.test.ts

@@ -194,7 +194,7 @@ describe('inPage', () => {
             {
               params: {
                 toolName: 'test-tool',
-                params: {arg: 'value'},
+                params: JSON.stringify({arg: 'value'}),
               },
               page: context.getSelectedMcpPage(),
             },
@@ -233,7 +233,7 @@ describe('inPage', () => {
               {
                 params: {
                   toolName: 'missing-tool',
-                  params: {},
+                  params: JSON.stringify({}),
                 },
                 page: context.getSelectedMcpPage(),
               },
@@ -282,7 +282,7 @@ describe('inPage', () => {
                 {
                   params: {
                     toolName: 'test-tool',
-                    params: {}, // Missing required 'arg'
+                    params: JSON.stringify({}), // Missing required 'arg'
                   },
                   page: context.getSelectedMcpPage(),
                 },
@@ -326,7 +326,7 @@ describe('inPage', () => {
             {
               params: {
                 toolName: 'test-tool',
-                params: {},
+                params: JSON.stringify({}),
               },
               page: context.getSelectedMcpPage(),
             },