[ui] Delay 'PreRegisteredView' instantiation

Rather then eagerly creating `PreRegisteredView` we just store the
`ViewRegistration` (now in a Map).

The plan is to create the `ViewManager` with a `Universe` instance.
Then we pass the `Universe` along when creating the `PreRegisteredView`
so we can then pass it along to `loadView`.

R=dsv@chromium.org

Bug: 451502260
Change-Id: I6264da50f429221055c98d7474e86c439ff847ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7207148
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>

Author: szuend

front_end/entrypoints/main/MainImpl.ts

@@ -947,7 +947,7 @@ export class MainMenuItem implements UI.Toolbar.Provider {
     contextMenu.appendItemsAtLocation('mainMenu');
     const moreTools =
         contextMenu.defaultSection().appendSubMenuItem(i18nString(UIStrings.moreTools), false, 'more-tools');
-    const viewExtensions = UI.ViewManager.getRegisteredViewExtensions();
+    const viewExtensions = UI.ViewManager.ViewManager.instance().getRegisteredViewExtensions();
     viewExtensions.sort((extension1, extension2) => {
       const title1 = extension1.title();
       const title2 = extension2.title();

front_end/panels/settings/SettingsScreen.ts

@@ -581,7 +581,7 @@ export class Revealer implements Common.Revealer.Revealer<Root.Runtime.Experimen
     }
 
     // Reveal settings views
-    for (const view of UI.ViewManager.getRegisteredViewExtensions()) {
+    for (const view of UI.ViewManager.ViewManager.instance().getRegisteredViewExtensions()) {
       const id = view.viewId();
       const location = view.location();
       if (location !== UI.ViewManager.ViewLocationValues.SETTINGS_VIEW) {

front_end/ui/legacy/ViewManager.ts

@@ -168,6 +168,8 @@ export class ViewManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
   private readonly locationNameByViewId = new Map<string, string>();
   private readonly locationOverrideSetting: Common.Settings.Setting<Record<string, string>>;
 
+  private readonly preRegisteredViews: PreRegisteredView[] = [];
+
   private constructor() {
     super();
 
@@ -180,9 +182,9 @@ export class ViewManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
 
     const viewsByLocation = new Map<ViewLocationValues|'none', PreRegisteredView[]>();
     for (const view of getRegisteredViewExtensions()) {
-      const location = view.location() || 'none';
+      const location = view.location || 'none';
       const views = viewsByLocation.get(location) || [];
-      views.push(view);
+      views.push(new PreRegisteredView(view));
       viewsByLocation.set(location, views);
     }
 
@@ -209,6 +211,7 @@ export class ViewManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
         throw new Error(`Invalid view ID '${viewId}'`);
       }
       this.views.set(viewId, view);
+      this.preRegisteredViews.push(view);
       // Use the preferred user location if available
       const locationName = preferredExtensionLocations[viewId] || location;
       this.locationNameByViewId.set(viewId, locationName as string);
@@ -241,6 +244,10 @@ export class ViewManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
     return toolbar;
   }
 
+  getRegisteredViewExtensions(): PreRegisteredView[] {
+    return this.preRegisteredViews;
+  }
+
   locationNameForViewId(viewId: string): string {
     const locationName = this.locationNameByViewId.get(viewId);
     if (!locationName) {
@@ -1004,7 +1011,6 @@ class StackLocation extends Location implements ViewLocation {
 export {
   getLocalizedViewLocationCategory,
   getRegisteredLocationResolvers,
-  getRegisteredViewExtensions,
   maybeRemoveViewExtension,
   registerLocationResolver,
   registerViewExtension,

front_end/ui/legacy/ViewRegistration.ts

@@ -7,7 +7,6 @@ import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 
 import type {ViewLocationResolver} from './View.js';
-import {PreRegisteredView} from './ViewManager.js';
 import type {Widget} from './Widget.js';
 
 const UIStrings = {
@@ -43,8 +42,6 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/ViewRegistration.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-const registeredViewExtensions: PreRegisteredView[] = [];
-
 export const enum ViewPersistence {
   CLOSEABLE = 'closeable',
   PERMANENT = 'permanent',
@@ -160,28 +157,25 @@ export interface ViewRegistration {
   featurePromotionId?: string;
 }
 
-const viewIdSet = new Set<string>();
+const registeredViewExtensions = new Map<string, ViewRegistration>();
+
 export function registerViewExtension(registration: ViewRegistration): void {
   const viewId = registration.id;
-  if (viewIdSet.has(viewId)) {
+  if (registeredViewExtensions.has(viewId)) {
     throw new Error(`Duplicate view id '${viewId}'`);
   }
-  viewIdSet.add(viewId);
-  registeredViewExtensions.push(new PreRegisteredView(registration));
+  registeredViewExtensions.set(viewId, registration);
 }
 
-export function getRegisteredViewExtensions(): PreRegisteredView[] {
-  return registeredViewExtensions.filter(
-      view => Root.Runtime.Runtime.isDescriptorEnabled({experiment: view.experiment(), condition: view.condition()}));
+export function getRegisteredViewExtensions(): ViewRegistration[] {
+  return registeredViewExtensions.values()
+      .filter(
+          view => Root.Runtime.Runtime.isDescriptorEnabled({experiment: view.experiment, condition: view.condition}))
+      .toArray();
 }
 
 export function maybeRemoveViewExtension(viewId: string): boolean {
-  const viewIndex = registeredViewExtensions.findIndex(view => view.viewId() === viewId);
-  if (viewIndex < 0 || !viewIdSet.delete(viewId)) {
-    return false;
-  }
-  registeredViewExtensions.splice(viewIndex, 1);
-  return true;
+  return registeredViewExtensions.delete(viewId);
 }
 
 const registeredLocationResolvers: LocationResolverRegistration[] = [];
@@ -202,10 +196,9 @@ export function getRegisteredLocationResolvers(): LocationResolverRegistration[]
 }
 
 export function resetViewRegistration(): void {
-  registeredViewExtensions.length = 0;
+  registeredViewExtensions.clear();
   registeredLocationResolvers.length = 0;
   viewLocationNameSet.clear();
-  viewIdSet.clear();
 }
 
 export const enum ViewLocationCategory {

front_end/ui/legacy/components/quick_open/CommandMenu.ts

@@ -201,7 +201,7 @@ export class CommandMenu {
         locations.set(name, category);
       }
     }
-    const views = UI.ViewManager.getRegisteredViewExtensions();
+    const views = UI.ViewManager.ViewManager.instance().getRegisteredViewExtensions();
     for (const view of views) {
       const viewLocation = view.location();
       const category = viewLocation && locations.get(viewLocation);