Commit 1a74495
Fix CfT binary path in downloadedChromeBinaryPath()
The GCS migration (16d736b) removed the download_chrome.py hook
that used to rename extracted directories (e.g. chrome-mac-arm64 →
chrome-mac, chrome-win64 → chrome-win). The new GCS deps extract
zips directly, preserving the nested arch-specific directory
structure. However, downloadedChromeBinaryPath() was not updated
to reflect this, breaking `npm start` with --browser=cft.
Align the paths with test/conductor/paths.ts::localChromePath()
which was correctly updated in the same migration commit.
(and I wanted to say hi! 😊)
Bug: none
Change-Id: If6006625f0d079663aee36f3240d1a6c4af948c5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7595336
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Owners-Override: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>1 parent 4dfe442 commit 1a74495
1 file changed
+5
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
| 170 | + | |
170 | 171 | | |
171 | | - | |
| 172 | + | |
172 | 173 | | |
173 | | - | |
| 174 | + | |
| 175 | + | |
174 | 176 | | |
175 | 177 | | |
176 | 178 | | |
177 | 179 | | |
178 | 180 | | |
179 | | - | |
| 181 | + | |
180 | 182 | | |
181 | 183 | | |
182 | 184 | | |
0 commit comments