Extract common var in UI helpers

Let' a avoid comment about sync. We have multiple places that
do that and are not currently in sync.

We can do this if we have infra to track this.

Bug: none
Change-Id: Ie6cfba8eebe12b33b4da51507383de0d003eb0cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7581708
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>

Author: Lightning00Blade

front_end/panels/console/ConsoleView.ts

@@ -72,7 +72,6 @@ import {
   ConsoleTableMessageView,
   ConsoleViewMessage,
   getMessageForElement,
-  MaxLengthForLinks,
 } from './ConsoleViewMessage.js';
 import {ConsoleViewport, type ConsoleViewportElement, type ConsoleViewportProvider} from './ConsoleViewport.js';
 
@@ -549,7 +548,7 @@ export class ConsoleView extends UI.Widget.VBox implements
     // the linkifiers live location change event.
     const throttler = new Common.Throttler.Throttler(100);
     const refilterMessages = (): Promise<void> => throttler.schedule(async () => this.onFilterChanged());
-    this.linkifier = new Components.Linkifier.Linkifier(MaxLengthForLinks);
+    this.linkifier = new Components.Linkifier.Linkifier(UI.UIUtils.MaxLengthForDisplayedURLsInConsole);
     this.linkifier.addEventListener(Components.Linkifier.Events.LIVE_LOCATION_UPDATED, refilterMessages);
 
     this.consoleMessages = [];

front_end/panels/console/ConsoleViewMessage.ts

@@ -2363,11 +2363,6 @@ export class ConsoleTableMessageView extends ConsoleViewMessage {
  */
 const MaxLengthToIgnoreHighlighter = 10000;
 
-/**
- * @constant
- */
-export const MaxLengthForLinks = 40;
-
 let maxTokenizableStringLength = 10000;
 let longStringVisibleLength = 5000;
 

front_end/panels/elements/NodeStackTraceWidget.ts

@@ -45,7 +45,7 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
 };
 
 export class NodeStackTraceWidget extends UI.Widget.VBox {
-  readonly #linkifier = new Components.Linkifier.Linkifier(MaxLengthForLinks);
+  readonly #linkifier = new Components.Linkifier.Linkifier(UI.UIUtils.MaxLengthForDisplayedURLsInConsole);
   readonly #view: View;
 
   constructor(view = DEFAULT_VIEW) {
@@ -81,5 +81,3 @@ export class NodeStackTraceWidget extends UI.Widget.VBox {
     this.#view(input, {}, this.contentElement);
   }
 }
-
-export const MaxLengthForLinks = 40;

front_end/panels/issues/AffectedResourcesView.ts

@@ -253,8 +253,7 @@ export abstract class AffectedResourcesView extends UI.TreeOutline.TreeElement {
     const sourceCodeLocation = document.createElement('td');
     sourceCodeLocation.classList.add('affected-source-location');
     if (sourceLocation) {
-      const maxLengthForDisplayedURLs = 40;  // Same as console messages.
-      const linkifier = new Components.Linkifier.Linkifier(maxLengthForDisplayedURLs);
+      const linkifier = new Components.Linkifier.Linkifier(UI.UIUtils.MaxLengthForDisplayedURLsInConsole);
       const sourceAnchor = linkifier.linkifyScriptLocation(
           target || null, sourceLocation.scriptId || null, sourceLocation.url as Platform.DevToolsPath.UrlString,
           sourceLocation.lineNumber, {columnNumber: sourceLocation.columnNumber, inlineFrameIndex: 0});

front_end/ui/legacy/UIUtils.ts

@@ -1553,6 +1553,7 @@ export function createFileSelectorElement(callback: (arg0: File) => void, accept
 }
 
 export const MaxLengthForDisplayedURLs = 150;
+export const MaxLengthForDisplayedURLsInConsole = 40;
 
 export class MessageDialog {
   static async show(header: string, message: string, where?: Element|Document, jslogContext?: string): Promise<void> {

front_end/ui/legacy/components/utils/JSPresentationUtils.ts

@@ -71,11 +71,6 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/utils/JSPresentationUtils.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-/**
- * Keep consistent with ConsoleViewMessage.MaxLengthForLinks.
- */
-const MAX_LINK_LENGTH = 40;
-
 function populateContextMenu(link: Element, event: Event): void {
   const contextMenu = new UI.ContextMenu.ContextMenu(event);
   event.consume(true);
@@ -193,7 +188,7 @@ function buildStackTraceRows(
         tabStop: Boolean(tabStops),
         inlineFrameIndex: 0,
         revealBreakpoint: previousStackFrameWasBreakpointCondition,
-        maxLength: MAX_LINK_LENGTH,
+        maxLength: UI.UIUtils.MaxLengthForDisplayedURLsInConsole,
       });
       link.setAttribute('jslog', `${VisualLogging.link('stack-trace').track({click: true})}`);
       link.addEventListener('contextmenu', populateContextMenu.bind(null, link));