豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Commit decba1f

Browse files
Liviu RauDevtools-frontend LUCI CQ
authored andcommitted
Add new infra topics to documentation
Bug: 441271617 Change-Id: Ic2c80c25d34aa94dc8f00bcc38b7c4f6df8c4829 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7079298 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org>
1 parent 08a4e28 commit decba1f

File tree

1 file changed

+32
-0
lines changed

1 file changed

+32
-0
lines changed

docs/contributing/infrastructure.md

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,27 @@ https://chromium.googlesource.com/chromium/tools/build/+/refs/heads/main/recipes
6868
and upload a CL for
6969
[`chromium/tools/build`](https://chromium.googlesource.com/chromium/tools/build/+/refs/heads/main).
7070

71+
It's good practice to also manually test your recipes. You can test your recipe
72+
changes against a build that was performed with the same recipes. To do so
73+
follow these steps:
74+
- authenticate with `led auth-login`
75+
- select a particular build that ran with your target recipe ([example](https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_linux_dbg/14161))
76+
- got to Infra tab and collect the Buildbucket id (8700153319150087425 for the example above)
77+
- run `led get-build --real-build 8700153319150087425 | led edit-recipe-bundle | led edit-system -p 25 | led launch` while in your local recipe checkout
78+
- collect the output link to your test build and verify that you got the expected result
79+
80+
## Pin older version of DevTools recipes to a branch
81+
82+
Updating a recipe that depends on DevTools repo recent changes can break the
83+
build in beta/stable/extended branches. If those changes cannot be back-merged
84+
into the branches you can pin the older version of the recipe to the branches in
85+
infra/config.
86+
87+
To do so update the `legacy_recipe` config in `definitions.star` with the number
88+
of the last branch you need the old version of the recipe to run on and with the
89+
revision hash of that version. Branches with number higher than the one you
90+
configured will run ToT recipe version. [Example](https://crrev.com/c/7003685)
91+
7192
## Updating test commands in the infrastructure
7293

7394
The DevTools recipes are defined in
@@ -228,6 +249,17 @@ Below is a detailed description of what happens in such a build:
228249
- fail the builder if tests failed in the deflaking phase
229250
- otherwise report build as passing
230251

252+
## Skip flake detection
253+
254+
Test that are already flaky can end up being updated in CLs that do not deal
255+
with the original flakiness nor can be blamed for introducing or increasing the
256+
flakiness of the test. However CQ builder will fail in Flake Detection steps
257+
because they picked up the test as it was being touched.
258+
259+
You can skip Flake Detection for your tests by adding the `Skip-Flake-Detection`
260+
CL footer (see example [CL](https://crrev.com/c/6994031)). Make sure you use the
261+
full path to your test.
262+
231263
### Common build failures
232264

233265
The first place where a build usually fails is on `bot_update` and this usually

0 commit comments

Comments
 (0)