豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Commit e5ee7c9

Browse files
authored
[Hotfix] Fix broken unit test blocking hotifx (#10434)
1 parent a14b029 commit e5ee7c9

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

tests/Tests.Stats.CollectAzureChinaCDNLogs/JobTests.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ public void InitFailsWithInvalidAccount()
3737
var configuration = GetDefaultConfiguration();
3838
var msiConfiguration = GetDefaultStorageMsiConfiguration();
3939

40-
Assert.ThrowsAny<RequestFailedException>(() => job.InitializeJobConfiguration(GetMockServiceProvider(configuration, msiConfiguration)));
40+
var ex = Assert.ThrowsAny<AggregateException>(() => job.InitializeJobConfiguration(GetMockServiceProvider(configuration, msiConfiguration)));
41+
Assert.IsType<RequestFailedException>(ex.InnerException);
4142
}
4243

4344
[Theory]
@@ -46,13 +47,13 @@ public void InitFailsWithInvalidAccount()
4647
[InlineData("AzureAccountConnectionStringDestination", null, typeof(ArgumentException))]
4748
[InlineData("AzureContainerNameDestination", null, typeof(ArgumentNullException))]
4849
[InlineData("AzureContainerNameSource", null, typeof(ArgumentNullException))]
49-
[InlineData("DestinationFilePrefix", null, typeof(RequestFailedException))]
50+
[InlineData("DestinationFilePrefix", null, typeof(AggregateException))]
5051
// empty values
5152
[InlineData("AzureAccountConnectionStringSource", "", typeof(ArgumentException))]
5253
[InlineData("AzureAccountConnectionStringDestination", "", typeof(ArgumentException))]
5354
[InlineData("AzureContainerNameDestination", "", typeof(ArgumentException))]
5455
[InlineData("AzureContainerNameSource", "", typeof(ArgumentException))]
55-
[InlineData("DestinationFilePrefix", "", typeof(RequestFailedException))]
56+
[InlineData("DestinationFilePrefix", "", typeof(AggregateException))]
5657
public void InitMissingArgArguments(string property, object value, Type exceptionType)
5758
{
5859
var job = new Job();
@@ -78,9 +79,9 @@ private static CollectAzureChinaCdnLogsConfiguration GetDefaultConfiguration()
7879
return new CollectAzureChinaCdnLogsConfiguration
7980
{
8081
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Test secret")]
81-
AzureAccountConnectionStringSource = "DefaultEndpointsProtocol=https;AccountName=name;AccountKey=cdummy4aadummyAAWhdummyAdummyA6A+dummydoAdummyJqdummymnm+H+2dummyA/dummygdummyqdummyKK==;EndpointSuffix=core.chinacloudapi.cn",
82+
AzureAccountConnectionStringSource = "DefaultEndpointsProtocol=https;AccountName=thisstorageaccountnameistoolong;AccountKey=cdummy4aadummyAAWhdummyAdummyA6A+dummydoAdummyJqdummymnm+H+2dummyA/dummygdummyqdummyKK==;EndpointSuffix=core.chinacloudapi.cn",
8283
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Test secret")]
83-
AzureAccountConnectionStringDestination = "DefaultEndpointsProtocol=https;AccountName=name;AccountKey=cdummy4aadummyAAWhdummyAdummyA6A+dummydoAdummyJqdummymnm+H+2dummyA/dummygdummyqdummyKK==;EndpointSuffix=core.windows.net",
84+
AzureAccountConnectionStringDestination = "DefaultEndpointsProtocol=https;AccountName=thisstorageaccountnameistoolong;AccountKey=cdummy4aadummyAAWhdummyAdummyA6A+dummydoAdummyJqdummymnm+H+2dummyA/dummygdummyqdummyKK==;EndpointSuffix=core.windows.net",
8485
AzureContainerNameDestination = "DestContainer",
8586
AzureContainerNameSource = "SourceContainer",
8687
DestinationFilePrefix = "SomePrfix",

0 commit comments

Comments
 (0)