Commit 19e3093
committed
fix(github-actions): improve error logging and fix ESM node resolution
We recently prioritized `module` over `main` but this results in browser
code being prioritized sometimes. We revert that change and keep the
original/default ESBuild main field order.
This unveils an issue with `jsonc-parser` though- which ships an UMD
file for `main` that cannot be bundled. We can work around this by
processing `jsonc-parser`'s ESM output directly and then using that
instead of leaving resolution to ESBuild for this package.
There is an issue for this being tracked: microsoft/node-jsonc-parser#571 parent a67b584 commit 19e3093
File tree
21 files changed
+120365
-110196
lines changed- .github/local-actions/changelog
- bazel/esbuild
- github-actions
- commit-message-based-labels
- lib
- create-pr-for-changes
- lib
- feature-request
- google-internal-tests
- lib
- labels-sync
- lock-closed
- lib
- org-file-sync
- post-approval-changes
- lib
- slash-commands
- lib
- ng-dev/caretaker
- tools/esm-interop
21 files changed
+120365
-110196
lines changedLarge diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| |||
Lines changed: 15890 additions & 14430 deletions
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| |||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
0 commit comments