fix(ng-dev): yarnpkg lockfile package cannot be bundled with ESM

ESBuild bundles CommonJS packages, but some cannot be due to use of
CJS-only features. The yarn lockfile is one package that needs to be
kept external for it to leverage CJS features through NodeJS built-in
ESM -> CJS interop.

Author: devversion

ng-dev/BUILD.bazel

@@ -5,6 +5,9 @@ NG_DEV_EXTERNALS = [
     # `typescript` is external because we want the project to provide a TypeScript version.
     # TODO: Figure out how we want to manage dependencies for the dev-infra tool.
     "typescript",
+    # Package uses `__filename` and `__dirname` and cannot be bundled in ESM. We do not
+    # intend to provide interop globals for this as it could hide other significant issues.
+    "@yarnpkg/lockfile",
 ]
 
 ts_library(

ng-dev/utils/resolve-yarn-bin.ts

@@ -11,7 +11,7 @@ import * as path from 'path';
 import which from 'which';
 
 import {isNodeJSWrappedError} from './nodejs-errors.js';
-import {parse as parseLockfile} from '@yarnpkg/lockfile';
+import lockfile from '@yarnpkg/lockfile';
 import {parse as parseYaml} from 'yaml';
 import {ChildProcess} from './child-process.js';
 import {Log} from './logging.js';
@@ -33,7 +33,7 @@ export interface YarnCommandInfo {
 
 /** List of Yarn configuration files and their parsing mechanisms. */
 export const yarnConfigFiles: ConfigWithParser[] = [
-  {fileName: '.yarnrc', parse: (c) => parseLockfile(c).object},
+  {fileName: '.yarnrc', parse: (c) => lockfile.parse(c).object},
   {fileName: '.yarnrc.yml', parse: (c) => parseYaml(c)},
 ];
 

ng-dev/utils/version-check.ts

@@ -8,7 +8,7 @@
 
 import * as path from 'path';
 import * as fs from 'fs';
-import {LockFileObject, parse as parseYarnLockfile} from '@yarnpkg/lockfile';
+import lockfile from '@yarnpkg/lockfile';
 import {
   ngDevNpmPackageName,
   workspaceRelativePackageJsonPath,
@@ -34,7 +34,7 @@ export async function verifyNgDevToolIsUpToDate(workspacePath: string): Promise<
   try {
     const lockFileContent = fs.readFileSync(workspaceDirLockFile, 'utf8');
     const packageJson = JSON.parse(fs.readFileSync(workspacePackageJsonFile, 'utf8')) as any;
-    const lockFile = parseYarnLockfile(lockFileContent);
+    const lockFile = lockfile.parse(lockFileContent);
 
     if (lockFile.type !== 'success') {
       throw Error('Unable to parse workspace lock file. Please ensure the file is valid.');
@@ -45,7 +45,7 @@ export async function verifyNgDevToolIsUpToDate(workspacePath: string): Promise<
       return true;
     }
 
-    const lockFileObject = lockFile.object as LockFileObject;
+    const lockFileObject = lockFile.object as lockfile.LockFileObject;
     const devInfraPkgVersion =
       packageJson?.dependencies?.[ngDevNpmPackageName] ??
       packageJson?.devDependencies?.[ngDevNpmPackageName] ??

package.json

@@ -45,6 +45,7 @@
     "@types/tmp": "^0.2.1",
     "@types/uuid": "^8.3.1",
     "@types/yargs": "^17.0.0",
+    "@yarnpkg/lockfile": "^1.1.0",
     "browser-sync": "^2.27.7",
     "clang-format": "1.8.0",
     "prettier": "2.7.0",
@@ -105,7 +106,6 @@
     "@types/wait-on": "^5.3.1",
     "@types/which": "^2.0.1",
     "@types/yarnpkg__lockfile": "^1.1.5",
-    "@yarnpkg/lockfile": "^1.1.0",
     "chalk": "^5.0.1",
     "cli-progress": "^3.7.0",
     "conventional-commits-parser": "^3.2.1",

tslint.json

@@ -8,6 +8,7 @@
       true,
       {
         "noNamedExports": [
+          "@yarnpkg/lockfile",
           "typescript",
           "multimatch",
           "semver",