refactor(ng-dev/release): indicate that a major stable release is first cut as @next

When we previously cut v14, it was not quite obvious to the caretaker
that the cut-stable action will publish to `@next` first (as it was
requested/required by the release checklist).

Author: devversion

ng-dev/release/publish/actions/cut-stable.ts

@@ -19,16 +19,19 @@ import {ExternalCommands} from '../external-commands.js';
  */
 export class CutStableAction extends ReleaseAction {
   private _newVersion = this._computeNewVersion();
+  private _isNewMajor = this.active.releaseCandidate!.isMajor;
 
   override async getDescription() {
-    const newVersion = this._newVersion;
-    return `Cut a stable release for the release-candidate branch (v${newVersion}).`;
+    if (this._isNewMajor) {
+      return `Cut a stable release for the release-candidate branch — published as \`@next\` (v${this._newVersion}).`;
+    } else {
+      return `Cut a stable release for the release-candidate branch — published as \`@latest\` (v${this._newVersion}).`;
+    }
   }
 
   override async perform() {
     const {branchName} = this.active.releaseCandidate!;
     const newVersion = this._newVersion;
-    const isNewMajor = this.active.releaseCandidate?.isMajor;
 
     // When cutting a new stable minor/major, we want to build the release notes capturing
     // all changes that have landed in the individual next and RC pre-releases.
@@ -58,12 +61,12 @@ export class CutStableAction extends ReleaseAction {
       releaseNotes,
       beforeStagingSha,
       branchName,
-      isNewMajor ? 'next' : 'latest',
+      this._isNewMajor ? 'next' : 'latest',
     );
 
     // If a new major version is published and becomes the "latest" release-train, we need
     // to set the LTS npm dist tag for the previous latest release-train (the current patch).
-    if (isNewMajor) {
+    if (this._isNewMajor) {
       const previousPatch = this.active.latest;
       const ltsTagForPatch = getLtsNpmDistTagOfMajor(previousPatch.version.major);
 

ng-dev/release/publish/test/common.spec.ts

@@ -46,13 +46,13 @@ describe('common release action logic', () => {
   });
 
   describe('version computation', () => {
-    const testReleaseTrain = new ActiveReleaseTrains({
-      releaseCandidate: new ReleaseTrain('10.1.x', parse('10.1.0-next.3')),
-      next: new ReleaseTrain('master', parse('10.2.0-next.0')),
-      latest: new ReleaseTrain('10.0.x', parse('10.0.1')),
-    });
-
     it('should not modify release train versions and cause invalid other actions', async () => {
+      const testReleaseTrain = new ActiveReleaseTrains({
+        releaseCandidate: new ReleaseTrain('10.1.x', parse('10.1.0-next.3')),
+        next: new ReleaseTrain('master', parse('10.2.0-next.0')),
+        latest: new ReleaseTrain('10.0.x', parse('10.0.1')),
+      });
+
       const {releaseConfig, githubConfig} = getTestConfigurationsForAction();
       const gitClient = getMockGitClient(githubConfig, /* useSandboxGitClient */ false);
       const descriptions: string[] = [];
@@ -74,6 +74,35 @@ describe('common release action logic', () => {
         `Cut a new release for an active LTS branch (0 active).`,
       ]);
     });
+
+    it('should properly show descriptions when a major is in RC-phase', async () => {
+      const testReleaseTrain = new ActiveReleaseTrains({
+        releaseCandidate: new ReleaseTrain('15.0.x', parse('15.0.0-rc.1')),
+        next: new ReleaseTrain('main', parse('15.1.0-next.0')),
+        latest: new ReleaseTrain('14.3.x', parse('14.3.1')),
+      });
+
+      const {releaseConfig, githubConfig} = getTestConfigurationsForAction();
+      const gitClient = getMockGitClient(githubConfig, /* useSandboxGitClient */ false);
+      const descriptions: string[] = [];
+
+      // Fake the NPM package request as otherwise the test would rely on `npmjs.org`.
+      fakeNpmPackageQueryRequest(releaseConfig.representativeNpmPackage, {'dist-tags': {}});
+
+      for (const actionCtor of actions) {
+        if (await actionCtor.isActive(testReleaseTrain, releaseConfig)) {
+          const action = new actionCtor(testReleaseTrain, gitClient, releaseConfig, testTmpDir);
+          descriptions.push(await action.getDescription());
+        }
+      }
+
+      expect(descriptions).toEqual([
+        'Cut a stable release for the release-candidate branch — published as `@next` (v15.0.0).',
+        'Cut a new patch release for the "14.3.x" branch (v14.3.2).',
+        `Cut a new next pre-release for the "15.0.x" branch (v15.0.0-rc.2).`,
+        `Cut a new release for an active LTS branch (0 active).`,
+      ]);
+    });
   });
 
   describe('publishing', () => {