fix(ng-dev): properly catch github API errors and print clean output (#877)

Currently when e.g. GitHub API merge fails with a 405 error, the whole
output is printed. This is super spammy and the actual GitHub error
message is not easy to spot. This fixes it by also catching non-403
GitHub API errors and printing them.

PR Close #877

Author: devversion

ng-dev/pr/merge/merge-pull-request.ts

@@ -56,11 +56,15 @@ export async function mergePullRequest(prNumber: number, flags: PullRequestMerge
       // Catch errors to the Github API for invalid requests. We want to
       // exit the script with a better explanation of the error.
       if (e instanceof GithubApiRequestError && e.status === 401) {
-        Log.error('Github API request failed. ' + e.message);
+        Log.error('Github API request failed: ' + bold(e.message));
         Log.error('Please ensure that your provided token is valid.');
         Log.warn(`You can generate a token here: ${GITHUB_TOKEN_GENERATE_URL}`);
         return false;
       }
+      if (e instanceof GithubApiRequestError) {
+        Log.error('Github API request failed: ' + bold(e.message));
+        return false;
+      }
       if (e instanceof UserAbortedMergeToolError) {
         Log.warn('Manually aborted merging..');
         return false;

ng-dev/pr/merge/messages.ts

@@ -24,5 +24,5 @@ export function getTargetedBranchesMessage(pullRequest: PullRequest): string {
   const targetBranchListAsString = pullRequest.targetBranches
     .map((b) => `  - ${bold(b)}`)
     .join('\n');
-  return `Pull request #${pullRequest.prNumber} will merge into:\n${targetBranchListAsString}`;
+  return `Pull Request #${pullRequest.prNumber} will merge into:\n${targetBranchListAsString}`;
 }