fix(bazel): spec-bundle rule should never consider transitive files

Only specs part of the direct sources, or only direct init files
should be considered by the rule.

Consider an example where one init file relies on another. The second
init file should not be picked up as bootstrap file, but instead should
just be loaded based on the direct `.init` file.

Author: devversion

bazel/spec-bundling/spec-entrypoint.bzl

@@ -37,30 +37,36 @@ def _create_entrypoint_file(base_package, spec_files, bootstrap_files):
 
 def _spec_entrypoint_impl(ctx):
     output = ctx.actions.declare_file("%s.mjs" % ctx.attr.name)
-    spec_depsets = []
-    bootstrap_depsets = []
+    spec_direct_deps = []
+    spec_all_deps = []
+    bootstrap_direct_deps = []
+    bootstrap_all_deps = []
 
     for dep in ctx.attr.deps:
         if JSModuleInfo in dep:
-            spec_depsets.append(dep[JSModuleInfo].sources)
+            spec_all_deps.append(dep[JSModuleInfo].sources)
+            spec_direct_deps.append(dep[JSModuleInfo].direct_sources)
         else:
-            spec_depsets.append(dep[DefaultInfo].files)
+            spec_all_deps.append(dep[DefaultInfo].files)
+            spec_direct_deps.append(dep[DefaultInfo].files)
 
     for dep in ctx.attr.bootstrap:
         if JSModuleInfo in dep:
-            bootstrap_depsets.append(dep[JSModuleInfo].sources)
+            bootstrap_all_deps.append(dep[JSModuleInfo].sources)
+            bootstrap_direct_deps.append(dep[JSModuleInfo].direct_sources)
         else:
-            bootstrap_depsets.append(dep[DefaultInfo].files)
+            bootstrap_all_deps.append(dep[DefaultInfo].files)
+            bootstrap_direct_deps.append(dep[DefaultInfo].files)
 
     # Note: `to_list()` is an expensive operation but we need to do this for every
     # dependency here in order to be able to filter out spec files from depsets.
-    all_spec_files = depset(transitive = spec_depsets).to_list()
-    spec_files = _filter_files(all_spec_files, ["spec", "test"])
+    direct_spec_files = depset(transitive = spec_direct_deps).to_list()
+    spec_files = _filter_files(direct_spec_files, ["spec", "test"])
 
     # Note: `to_list()` is an expensive operation but we need to do this for every
     # dependency here in order to be able to filter out spec files from depsets.
-    all_bootstrap_files = depset(transitive = bootstrap_depsets).to_list()
-    bootstrap_files = _filter_files(all_bootstrap_files, ["init"])
+    direct_bootstrap_files = depset(transitive = bootstrap_direct_deps).to_list()
+    bootstrap_files = _filter_files(direct_bootstrap_files, ["init"])
 
     ctx.actions.write(
         output = output,
@@ -73,7 +79,7 @@ def _spec_entrypoint_impl(ctx):
         DefaultInfo(files = out_depset),
         JSModuleInfo(
             direct_sources = out_depset,
-            sources = depset(transitive = [out_depset] + spec_depsets + bootstrap_depsets),
+            sources = depset(transitive = [out_depset] + spec_all_deps + bootstrap_all_deps),
         ),
     ]
 

bazel/spec-bundling/test/BUILD.bazel

@@ -4,11 +4,17 @@ load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test")
 load("//bazel/spec-bundling:index.bzl", "spec_bundle")
 load("//tools:defaults.bzl", "ts_library")
 
+ts_library(
+    name = "transitive_should_not_be_loaded",
+    srcs = ["should_not_be_picked_up.spec.ts"],
+)
+
 ts_library(
     name = "test_async_await_lib",
     testonly = True,
     srcs = ["async-await.spec.ts"],
     deps = [
+        ":transitive_should_not_be_loaded",
         "@npm//@angular/core",
         "@npm//@angular/platform-browser-dynamic",
         "@npm//@types/jasmine",
@@ -24,6 +30,7 @@ ts_library(
     testonly = True,
     srcs = ["core_apf_esm_test.ts"],
     deps = [
+        ":transitive_should_not_be_loaded",
         "@npm//@angular/core",
         "@npm//@types/jasmine",
     ],
@@ -34,6 +41,7 @@ ts_library(
     testonly = True,
     srcs = ["core_invalid_linker_decl.spec.ts"],
     deps = [
+        ":transitive_should_not_be_loaded",
         "@npm//@angular/core",
         "@npm//@types/jasmine",
     ],

bazel/spec-bundling/test/should_not_be_picked_up.spec.ts

@@ -0,0 +1 @@
+throw new Error('this file should not be loaded at all!');