fix: multiple static lookup (#1215)

* fix: multiple static lookup

* change names of test

Author: jorgsowa

src/parser/variable.js

@@ -216,14 +216,6 @@ module.exports = {
           break;
         }
         case this.tok.T_DOUBLE_COLON:
-          // @see https://github.com/glayzzle/php-parser/issues/107#issuecomment-354104574
-          if (
-            result.kind === "staticlookup" &&
-            result.offset.kind === "identifier"
-          ) {
-            this.error();
-          }
-
           node = this.node("staticlookup");
           result = node(result, this.read_what(true));
 

test/snapshot/__snapshots__/expr.test.js.snap

@@ -224,13 +224,6 @@ Program {
       "message": "Parse Error : syntax error, unexpected 'bar' (T_STRING), expecting ';' on line 1",
       "token": "'bar' (T_STRING)",
     },
-    Error {
-      "expected": undefined,
-      "kind": "error",
-      "line": 1,
-      "message": "Parse Error : syntax error, unexpected '::' (T_DOUBLE_COLON) on line 1",
-      "token": "'::' (T_DOUBLE_COLON)",
-    },
   ],
   "kind": "program",
 }

test/snapshot/__snapshots__/variable.test.js.snap

@@ -65,6 +65,75 @@ Program {
 }
 `;
 
+exports[`Test variables Check errors chained static lookup foo::bar::baz 1`] = `
+Program {
+  "children": [
+    ExpressionStatement {
+      "expression": StaticLookup {
+        "kind": "staticlookup",
+        "offset": Identifier {
+          "kind": "identifier",
+          "name": "baz",
+        },
+        "what": StaticLookup {
+          "kind": "staticlookup",
+          "offset": Identifier {
+            "kind": "identifier",
+            "name": "bar",
+          },
+          "what": Name {
+            "kind": "name",
+            "name": "foo",
+            "resolution": "uqn",
+          },
+        },
+      },
+      "kind": "expressionstatement",
+    },
+  ],
+  "errors": [],
+  "kind": "program",
+}
+`;
+
+exports[`Test variables Check errors chained static lookup on property lookup 1`] = `
+Program {
+  "children": [
+    ExpressionStatement {
+      "expression": StaticLookup {
+        "kind": "staticlookup",
+        "offset": Identifier {
+          "kind": "identifier",
+          "name": "baz",
+        },
+        "what": StaticLookup {
+          "kind": "staticlookup",
+          "offset": Identifier {
+            "kind": "identifier",
+            "name": "bar",
+          },
+          "what": PropertyLookup {
+            "kind": "propertylookup",
+            "offset": Identifier {
+              "kind": "identifier",
+              "name": "foo",
+            },
+            "what": Name {
+              "kind": "name",
+              "name": "this",
+              "resolution": "uqn",
+            },
+          },
+        },
+      },
+      "kind": "expressionstatement",
+    },
+  ],
+  "errors": [],
+  "kind": "program",
+}
+`;
+
 exports[`Test variables Check errors should be ? 1`] = `
 Program {
   "children": [
@@ -147,90 +216,6 @@ Program {
 }
 `;
 
-exports[`Test variables Check errors should fail foo::bar::baz 1`] = `
-Program {
-  "children": [
-    ExpressionStatement {
-      "expression": StaticLookup {
-        "kind": "staticlookup",
-        "offset": Identifier {
-          "kind": "identifier",
-          "name": "baz",
-        },
-        "what": StaticLookup {
-          "kind": "staticlookup",
-          "offset": Identifier {
-            "kind": "identifier",
-            "name": "bar",
-          },
-          "what": Name {
-            "kind": "name",
-            "name": "foo",
-            "resolution": "uqn",
-          },
-        },
-      },
-      "kind": "expressionstatement",
-    },
-  ],
-  "errors": [
-    Error {
-      "expected": undefined,
-      "kind": "error",
-      "line": 1,
-      "message": "Parse Error : syntax error, unexpected '::' (T_DOUBLE_COLON) on line 1",
-      "token": "'::' (T_DOUBLE_COLON)",
-    },
-  ],
-  "kind": "program",
-}
-`;
-
-exports[`Test variables Check errors should fail on double static lookup 1`] = `
-Program {
-  "children": [
-    ExpressionStatement {
-      "expression": StaticLookup {
-        "kind": "staticlookup",
-        "offset": Identifier {
-          "kind": "identifier",
-          "name": "baz",
-        },
-        "what": StaticLookup {
-          "kind": "staticlookup",
-          "offset": Identifier {
-            "kind": "identifier",
-            "name": "bar",
-          },
-          "what": PropertyLookup {
-            "kind": "propertylookup",
-            "offset": Identifier {
-              "kind": "identifier",
-              "name": "foo",
-            },
-            "what": Name {
-              "kind": "name",
-              "name": "this",
-              "resolution": "uqn",
-            },
-          },
-        },
-      },
-      "kind": "expressionstatement",
-    },
-  ],
-  "errors": [
-    Error {
-      "expected": undefined,
-      "kind": "error",
-      "line": 1,
-      "message": "Parse Error : syntax error, unexpected '::' (T_DOUBLE_COLON) on line 1",
-      "token": "'::' (T_DOUBLE_COLON)",
-    },
-  ],
-  "kind": "program",
-}
-`;
 
 exports[`Test variables Check errors should fail on property lookup on static lookup 1`] = `
 Program {

test/snapshot/expr.test.js

@@ -299,7 +299,7 @@ describe("Test expressions", function () {
     expect(
       parser.parseEval(`($a++)($foo)->bar{$baz}::foo();`),
     ).toMatchSnapshot();
-    // expect error :
+    // expect error: `bar` is not a valid continuation after `($a++)`
     expect(
       parser.parseEval(`($a++)bar::foo::baz;`, {
         parser: {

test/snapshot/variable.test.js

@@ -126,14 +126,8 @@ describe("Test variables", function () {
       ).toMatchSnapshot();
     });
 
-    it("should fail on double static lookup", function () {
-      expect(
-        parser.parseEval(["this->foo::bar::baz;"].join("\n"), {
-          parser: {
-            suppressErrors: true,
-          },
-        }),
-      ).toMatchSnapshot();
+    it("chained static lookup on property lookup", function () {
+      expect(parser.parseEval("this->foo::bar::baz;")).toMatchSnapshot();
     });
 
     it("should fail on property lookup on static lookup", function () {
@@ -156,14 +150,8 @@ describe("Test variables", function () {
       ).toMatchSnapshot();
     });
 
-    it("should fail foo::bar::baz", function () {
-      expect(
-        parser.parseEval("foo::bar::baz", {
-          parser: {
-            suppressErrors: true,
-          },
-        }),
-      ).toMatchSnapshot();
+    it("chained static lookup foo::bar::baz", function () {
+      expect(parser.parseEval("foo::bar::baz")).toMatchSnapshot();
     });
   });