Commit aecc4a7
Handle cancellation in auth flow; use logService.error with Error arg
Address review feedback on PR #5078:
- Handle isCancellationError (and token.isCancellationRequested) by
throwing CancellationError instead of the generic auth-failed error,
so user-dismissed sign-in prompts cancel cleanly.
- Use logService.error(error, 'Authorization failed') per ILogService
guidance rather than interpolating the error into the message string.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent d0945a9 commit aecc4a7
File tree
1 file changed
+5
-1
lines changed- src/extension/chatSessions/vscode-node
1 file changed
+5
-1
lines changedLines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
1698 | 1699 | | |
1699 | 1700 | | |
1700 | 1701 | | |
1701 | | - | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
1702 | 1706 | | |
1703 | 1707 | | |
1704 | 1708 | | |
| |||
0 commit comments