High contrast icons for Pull Requests #191306
Replies: 4 comments 2 replies
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
@dgilmanAIDENTIFIED we've recently shipped some fixes after reviewing your feedback. Can you confirm the changes are live for you please? And feel free to let us know any additional thoughts! |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the change! Maybe more is coming in the 2nd PR but it seems to misunderstand the ask. The problem is not contrast against the background - white or black, both have contrast with the PR icons. My issue is with the contrast across the icons themselves. Maybe the change has not fully rolled out yet but togging the high contrast mode on is darkening the green PR icon making it contrast less against the already dark PR draft icon. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Product Feedback
Body
Please consider adding high contrast icons to the high contrast theme on the "Pull Request" page. The Pull Request page has a little icon indicating each pull request's status. The high contrast theme doesn't have a high contrast version of these icons. In particular, the black icon for a draft PR and the green icon for an open PR have similar brightness and are hard to distinguish.
Beta Was this translation helpful? Give feedback.
All reactions