豆豆友情提示：这是一个非官方 GitHub 代理镜像，主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。

chore: implement trigger extension action#1049

Merged

nroscino merged 11 commits intomainfrom

feat/trigger-extension-action

Mar 2, 2026

Contributor

nroscino commented Feb 26, 2026

This PR implements the ability to trigger an extension action by passing it an extension id.
It uses puppeteer internals and the canary chrome version in tests since the TriggerAction CDP command is still not available in the current stable release.

OrKoN reviewed

View reviewed changes

tests/tools/extensions.test.ts Outdated

OrKoN reviewed

View reviewed changes

tests/tools/extensions.test.ts Outdated

nroscino changed the title ~~feat: implement trigger extension action~~ chore: implement trigger extension action

nroscino added 3 commits

February 27, 2026 15:05


          feat: implement trigger extension action

c86de45


          chore: fixed type cast error

cfaec9c


          chore: added download of canary to ci

632f65a

nroscino force-pushed the feat/trigger-extension-action branch from 765ad8c to 632f65a Compare

February 27, 2026 17:30


          chore: fix lint

802b5f7

nroscino marked this pull request as ready for review

February 27, 2026 17:48

OrKoN reviewed

View reviewed changes

tests/tools/extensions.test.ts Outdated

nroscino added 2 commits

March 2, 2026 09:37


          chore: removing unnecessary channel specification

fb1215b


          Merge branch 'main' into feat/trigger-extension-action

41b9d3a

OrKoN reviewed

View reviewed changes

tests/utils.ts Outdated

OrKoN reviewed

View reviewed changes

tests/tools/extensions.test.ts Outdated

OrKoN reviewed

View reviewed changes

tests/tools/extensions.test.ts Outdated

nroscino requested a review from OrKoN

March 2, 2026 13:12

nroscino commented

View reviewed changes

tests/tools/extensions.test.js.snapshot Outdated

OrKoN reviewed

View reviewed changes

tests/utils.ts Outdated

OrKoN reviewed

View reviewed changes

tests/utils.ts Outdated

OrKoN reviewed

View reviewed changes

tests/tools/extensions.test.ts Outdated

OrKoN reviewed

View reviewed changes

tests/tools/extensions.test.ts Outdated


          chore: trigger action test updated to use snapshot tests

417cdf5

nroscino force-pushed the feat/trigger-extension-action branch from 5463cdf to 417cdf5 Compare

March 2, 2026 13:24


          refactor: address pr comments

4d5a62a

OrKoN approved these changes

View reviewed changes

nroscino added 2 commits

March 2, 2026 16:37


          chore: improving test reliability

012b30e


          Merge branch 'main' into feat/trigger-extension-action

c2cf318

nroscino enabled auto-merge

March 2, 2026 15:44


          Merge branch 'main' into feat/trigger-extension-action

480f0fa

nroscino added this pull request to the merge queue

Merged via the queue into main with commit e5973fd

31 of 33 checks passed

nroscino deleted the feat/trigger-extension-action branch

March 2, 2026 16:27

Member

mathiasbynens commented Mar 5, 2026 •

edited

Loading

~~For next time, please mark features like this as feat: rather than chore: so that it shows up properly in release notes & changelogs.~~

Member

mathiasbynens commented Mar 5, 2026 •

edited

Loading

For next time, please mark features like this as feat: rather than chore: so that it shows up properly in release notes & changelogs.

Ignore this — it’s not a released feature yet, so chore: is actually the right thing.

Once the CDP APIs are available in Stable Chrome, and docs have been updated, we can separately enable the feature by default (example: #1100). That PR should then be marked as feat:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet