Conversation
wolfib
approved these changes
Mar 20, 2026
Collaborator
|
Super nit: this should have been marked as a You can use the following to update it after the fact - https://github.com/googleapis/release-please?tab=readme-ov-file#how-can-i-fix-release-notes |
OrKoN
pushed a commit
to mvanhorn/chrome-devtools-mcp
that referenced
this pull request
Apr 1, 2026
The changes in the PR intercepts the name of the MCP client right after server initialization, coverts it into one of the existing enum values, and append it with the telemetry request. Note that the client name is unset if there is no client connected yet. This means the server_start event won't have a client name. Tested with gemini-cli. --------- Co-authored-by: Yulun Zeng <yulunz@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in the PR intercepts the name of the MCP client right after server initialization, coverts it into one of the existing enum values, and append it with the telemetry request.
Note that the client name is unset if there is no client connected yet. This means the server_start event won't have a client name.
Tested with gemini-cli.
BEGIN_COMMIT_OVERRIDE
fix(telemetry): record client name
END_COMMIT_OVERRIDE