Merged
Conversation
OrKoN
force-pushed
the
orkon/ensure-extensions
branch
2 times, most recently
from
8a1214e to
1d3179e
Compare
OrKoN
force-pushed
the
orkon/ensure-extensions
branch
from
1d3179e to
fd19710
Compare
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
LGTM with comments
- Did you miss the memory snapshot place?
- Feature work: Should we ban the use of fs/path in the repo and create our wrappers to manage this in one place?
Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
Collaborator
Author
Yep, fixed!
Note sure, I think there could legitimate uses of fs/path but if we can lint all places where we read/write tools for tools (excluding daemons, cli, metrics). I think it would be great. Yeah maybe we can just ban it in tools/. With Puppeteer APIs it is not so straightforward. |
Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
OrKoN
force-pushed
the
orkon/ensure-extensions
branch
from
171e42f to
d2989b0
Compare
Lightning00Blade
approved these changes
Apr 15, 2026
beaufortfrancois
pushed a commit
to beaufortfrancois/chrome-devtools-mcp
that referenced
this pull request
Apr 16, 2026
This PR ensures the extensions for the file outputs of different types minimizing the chance of misuse. The input filePath, thus, might be modified but it should not be an issue for clients as the final output path is returned to the clients in the response. Closes ChromeDevTools#1864 --------- Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
wolfib
pushed a commit
that referenced
this pull request
Apr 16, 2026
This PR ensures the extensions for the file outputs of different types minimizing the chance of misuse. The input filePath, thus, might be modified but it should not be an issue for clients as the final output path is returned to the clients in the response. Closes #1864 --------- Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
This was referenced Apr 16, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
Extensions are enforced since #1867
wolfib
pushed a commit
that referenced
this pull request
Apr 20, 2026
Extensions are enforced since #1867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the extensions for the file outputs of different types minimizing the chance of misuse. The input filePath, thus, might be modified but it should not be an issue for clients as the final output path is returned to the clients in the response.
Closes #1864