fix(cli): correct WebP MIME type check in handleResponse ('webp' → 'image/webp')#1899
Merged
OrKoN merged 1 commit intoChromeDevTools:mainfrom Apr 20, 2026
Merged
Conversation
…onse (Closes ChromeDevTools#1898) Signed-off-by: cocoon <54054995+kuishou68@users.noreply.github.com>
41d1ea7 to
c53deaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
src/daemon/client.tswhere the MIME type case for WebP images was'webp'instead of the correct'image/webp'.Problem
In
handleResponse, the switch statement for determining file extension used the incorrect string'webp'as the MIME type. Since browsers and servers sendimage/webpas the MIME type, the case never matched, and all WebP images were saved with a.pngextension instead of.webp.Testing
WebP screenshots/images returned by the tool will now correctly receive the
.webpextension.Closes #1898
Signed-off-by: cocoon 54054995+kuishou68@users.noreply.github.com