feat: report console issues in list_console_messages#505
Merged
Conversation
OrKoN
reviewed
Oct 31, 2025
OrKoN
reviewed
Oct 31, 2025
OrKoN
reviewed
Oct 31, 2025
OrKoN
reviewed
Oct 31, 2025
Collaborator
|
There are conflicts with the main branch. Could you please rebase? |
OrKoN
reviewed
Nov 6, 2025
OrKoN
reviewed
Nov 6, 2025
9665ceb to
0a00958
Compare
OrKoN
reviewed
Nov 11, 2025
Collaborator
OrKoN
left a comment
There was a problem hiding this comment.
Thanks! let's also add tests to make sure everything is working end-to-end and please address the lint and formatting issues.
f964f7b to
7fef676
Compare
7fef676 to
0aa6659
Compare
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
Collaborator
I think we still need a e2e test similar to tests in tests/McpContext.test.ts in which we use Puppeteer to actually navigate to a page that has an issue. We can pick an issue that is easy to trigger via page.setContent(). |
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
OrKoN
reviewed
Nov 14, 2025
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
5480ba1 to
51e1d9b
Compare
OrKoN
approved these changes
Nov 17, 2025
Collaborator
|
LGTM thanks! |
OrKoN
added a commit
that referenced
this pull request
Dec 2, 2025
Now that all PRs by @nattallius have landed, this PR removes the feature flag introduced in #575 and makes issues available by default. - list_console_messages has a new message type called `issue` to filter for DevTools issues - get_console_message returns details for the issues. DevTools issues help to identify and fix problems on web pages. See https://developer.chrome.com/docs/devtools/issues for more details. PRs contributing this feature: - #505 - #594 - #594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: report console issues in list_console_messages
END_COMMIT_OVERRIDE