chore: change puppeteer/devtools connection adapter#602
Merged
Conversation
szuend
force-pushed
the
cdp-connection-puppeteer
branch
from
9c74255 to
911344e
Compare
OrKoN
approved these changes
Nov 24, 2025
szuend
force-pushed
the
cdp-connection-puppeteer
branch
from
911344e to
88ebcfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather then adapting on the transport layer, we adapt the puppeteer
CDPSession/Connectionand make them look like aCDPConnection. The class assumes that callers create a dedicatedCDPSessionto be used.The
PuppeteerDevToolsConnectioninstalls a generic'*'event listener on all child sessions to funnel all CDP events into DevTools viaCDPConnectionObservers. As pointed out in the code comment, we don't need to recursively listen to'sessionattached'events on child sessions: Nestedsessionattachedevents are reported on all parent sessions.While not strictly necessary,
PuppeteerDevToolsConnectionalso uninstalls the CDP event listener when a session gets detached (modulo the root puppeteerCDPSession).