fix: apply pagination to network request output#970
Closed
AI-Reviewer-QS wants to merge 1 commit intoChromeDevTools:mainfrom
Closed
fix: apply pagination to network request output#970AI-Reviewer-QS wants to merge 1 commit intoChromeDevTools:mainfrom
AI-Reviewer-QS wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
Network request pagination was only cosmetic - the pagination header showed "Showing 1-10 of 30" but all 30 requests were rendered in both the text and structured content output. The format() method was computing pagination on raw requests but then iterating over all pre-built NetworkFormatter instances from handle(). Fix by applying pagination to the formatter array directly, matching the pattern already used by console message pagination. Also removed a redundant re-fetch of network requests in format() since the formatters from handle() already contain the filtered data.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@nroscino PTAL |
Contributor
|
This #980 addresses the issue without deleting unnecessary code. Closing. |
madhaviai
pushed a commit
to madhaviai/chrome-devtools-mcp
that referenced
this pull request
Feb 17, 2026
wolfib
pushed a commit
to wolfib/chrome-devtools-mcp
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format()method computed pagination on raw requests but then iterated over all pre-builtNetworkFormatterinstances fromhandle(), ignoring the paginated subsetformat()since the formatters fromhandle()already contain the filtered dataTest plan
returns first page by default- now only includes 10 of 30 requestsreturns subsequent page when pageIdx provided- shows correct page slicehandles invalid page number by showing first page- shows first page subset