豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Commit d5701ce

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
[cleanup] Remove WindowBoundsService
Replaced with a slim down version in the form of UI.UIUtils.getDevToolsBoundingElement Which provides the save logic Fixed: 454462779 Change-Id: Ie8934aebf58584b9d2392519d4a8c82d1691753d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7079556 Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
1 parent decba1f commit d5701ce

File tree

17 files changed

+104
-237
lines changed

17 files changed

+104
-237
lines changed

config/gni/devtools_grd_files.gni

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -739,7 +739,6 @@ grd_files_bundled_sources = [
739739
"front_end/services/puppeteer/puppeteer.js",
740740
"front_end/services/trace_bounds/trace_bounds.js",
741741
"front_end/services/tracing/tracing.js",
742-
"front_end/services/window_bounds/window_bounds.js",
743742
"front_end/third_party/acorn/acorn.js",
744743
"front_end/third_party/chromium/client-variations/client-variations.js",
745744
"front_end/third_party/codemirror.next/chunk/angular.js",
@@ -2094,7 +2093,6 @@ grd_files_unbundled_sources = [
20942093
"front_end/services/tracing/FreshRecording.js",
20952094
"front_end/services/tracing/PerformanceTracing.js",
20962095
"front_end/services/tracing/TracingManager.js",
2097-
"front_end/services/window_bounds/WindowBoundsService.js",
20982096
"front_end/third_party/acorn/package/dist/acorn.mjs",
20992097
"front_end/third_party/chromium/client-variations/ClientVariations.js",
21002098
"front_end/third_party/codemirror/package/addon/runmode/runmode-standalone.mjs",

front_end/panels/common/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ devtools_ui_module("common") {
4343
"../../models/extensions:bundle",
4444
"../../models/geometry:bundle",
4545
"../../models/persistence:bundle",
46-
"../../services/window_bounds:bundle",
4746
"../../ui/components/buttons:bundle",
4847
"../../ui/components/icon_button:bundle",
4948
"../../ui/components/snackbars:bundle",

front_end/panels/common/BadgeNotification.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
66
import * as Host from '../../core/host/host.js';
77
import * as i18n from '../../core/i18n/i18n.js';
88
import * as Badges from '../../models/badges/badges.js';
9-
import * as WindowBoundsService from '../../services/window_bounds/window_bounds.js';
109
import * as Buttons from '../../ui/components/buttons/buttons.js';
1110
import * as UI from '../../ui/legacy/legacy.js';
1211
import * as Lit from '../../ui/lit/lit.js';
@@ -166,8 +165,7 @@ export class BadgeNotification extends UI.Widget.Widget {
166165

167166
#positionNotification(): void {
168167
const boundingRect = this.contentElement.getBoundingClientRect();
169-
const container =
170-
WindowBoundsService.WindowBoundsService.WindowBoundsServiceImpl.instance().getDevToolsBoundingElement();
168+
const container = UI.UIUtils.getDevToolsBoundingElement();
171169
this.contentElement.positionAt(
172170
LEFT_OFFSET, container.clientHeight - boundingRect.height - BOTTOM_OFFSET, container);
173171
}

front_end/services/window_bounds/BUILD.gn

Lines changed: 0 additions & 20 deletions
This file was deleted.

front_end/services/window_bounds/WindowBoundsService.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.

front_end/services/window_bounds/window_bounds.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

front_end/ui/components/dialogs/BUILD.gn

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ devtools_ui_module("dialogs") {
2323
]
2424
deps = [
2525
"../../../core/platform:bundle",
26-
"../../../services/window_bounds:bundle",
26+
"../../legacy:bundle",
2727
"../buttons:bundle",
2828
"../helpers:bundle",
2929
"../render_coordinator:bundle",
@@ -53,8 +53,8 @@ devtools_ui_module("unittests") {
5353
deps = [
5454
":bundle",
5555
"../../../core/platform:bundle",
56-
"../../../services/window_bounds:bundle",
5756
"../../../testing",
57+
"../../legacy:bundle",
5858
"../render_coordinator:bundle",
5959
]
6060
}

0 commit comments

Comments
 (0)