Restore to project with single TargetFramework must not condition props

[nguerrera]

A project declaring a single TFM, e.g <TargetFramework>netstandard1.0</TargetFramework> will do so after props are imported. As such, if the .g.props file has a $(TargetFramework) condition as it does today, the condition will never be true, and the props will never be imported.

Nuget needs to distinguish the single TFM case and not emit conditions to the .g.props file (and probably not to the .g.targets either for the sake of consistency).

[emgarten]

What is the expected behavior for buildCrossTargeting? Are they left out or are they also put in without a condition?

[nguerrera]

They should be left out of the single TFM case. There is no outer build there.

[emgarten]

They should be left out of the single TFM case. There is no outer build there.

That makes sense. For Pack then it seems like the targets file will need to be under both buildCrossTargeting and build, one will be used for multiple TFMs, and the other for a single TFM. //cc @rohit21agrawal

[emgarten]

@nguerrera what is the expected behavior if a single TFM is passed in <TargetFrameworks>?

[eerhardt]

what is the expected behavior if a single TFM is passed in ?

The same behavior as if multiple TFMs are specified in $(TargetFrameworks). There is an "outer" build, and NuGet would add the single condition on the Import.

[emgarten]

The same behavior as if multiple TFMs are specified in $(TargetFrameworks). There is an "outer" build, and NuGet would add the single condition on the Import.

Thanks for confirming. NuGet will need to keep track of how it got the single framework to decide if buildCrossTargeting and TFM conditionals are used then.