Update Preview dialog to be less confusing#1629
Merged
PatoBeltran merged 1 commit intodevfrom Aug 14, 2017
Merged
Conversation
|
@PatoBeltran, |
PatoBeltran
requested review from
alpaix,
emgarten,
jainaashish,
karann-msft,
mishra14,
nkolev92,
rohit21agrawal,
rrelyea and
zhili1208
Member
|
@PatoBeltran Can you paste images of the dialog before and after the change? |
karann-msft
reviewed
Aug 9, 2017
There was a problem hiding this comment.
Since, we no longer have the first text block, we should consider moving this text block to Grid.Row = "0" and move any other items below up by one as well.
Contributor
Author
|
@nkolev92 here is how the dialog looks with and without this change. New behavior Old behavior @karann-msft addressed comment |
PatoBeltran
force-pushed
the
dev-patobeltran-adding-package-message-fix
branch
2 times, most recently
from
37890b0 to
3832a8b
Compare
|
|
nkolev92
approved these changes
Aug 11, 2017
PatoBeltran
force-pushed
the
dev-patobeltran-adding-package-message-fix
branch
from
3832a8b to
aa030cf
Compare
PatoBeltran
force-pushed
the
dev-patobeltran-adding-package-message-fix
branch
from
aa030cf to
cd99208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes NuGet/Home#5641