Conversation
nkolev92
approved these changes
Sep 30, 2020
| - Visual Studio extension development. | ||
| - Desktop development with C++ | ||
| - [Windows 10 SDK](https://dev.windows.com/en-US/downloads/windows-10-sdk) | ||
| - [Windows 10 SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/) |
Member
There was a problem hiding this comment.
I'm not if this is still needed for building. I think it's needed if you want to run all E2E tests though.
I created a follow up. NuGet/Home#10096
Member
|
ah, I forgot, can you please create a tracking issue for this @mholo65 We want to have every commit correlated to an issue. |
Contributor
Author
|
@nkolev92 thanks! Submitted issue and updated description. |
campersau
reviewed
Oct 1, 2020
zivkan
approved these changes
Oct 3, 2020
Member
|
@mholo65 This branch also needs to be rebased onto the latest dev. |
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Contributor
Author
|
@zivkan rebased. |
Member
|
This must have been the unluckiest PR we ever had. I swear I had to run about 10-15 builds before there was one without flaky failures. Finally a green build 🥳 . @mholo65 thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#10099
Regression: No
Fix
Details: This fixes a broken link in contributing documentation.
Testing/Validation
Tests Added: No
Reason for not adding tests: Only documentation
Validation: -