[NSJ -> STJ]Migrate AutoComplete#7298
Draft
Nigusu-Allehu wants to merge 2 commits intodev-feature-nsj-stj-migrationfrom
Draft
[NSJ -> STJ]Migrate AutoComplete#7298Nigusu-Allehu wants to merge 2 commits intodev-feature-nsj-stj-migrationfrom
Nigusu-Allehu wants to merge 2 commits intodev-feature-nsj-stj-migrationfrom
Conversation
richlander
reviewed
Apr 17, 2026
|
|
||
| var queryUri = queryUrl.Uri; | ||
| var results = await _client.GetJObjectAsync( | ||
| AutoCompleteModel results = await _client.ProcessStreamAsync( |
There was a problem hiding this comment.
I am surprised that AutoCompleteModel is always non-null. Is that correct?
Does this library not have nullable enabled?
richlander
reviewed
Apr 17, 2026
| // Resolve all the objects | ||
| var outputs = new List<string>(); | ||
| foreach (var result in data) | ||
| if (results?.Data == null) |
There was a problem hiding this comment.
You could adopt the null-coalescing syntax:
var returnValue = results?.Data.Where(item => item != null && item.StartsWith(packageIdPrefix, StringComparison.OrdinalIgnoreCase));
return returnValue ?? Enumerable.Empty<string>();Or some variant of that.
richlander
reviewed
Apr 17, 2026
| var results = await _client.GetJObjectAsync( | ||
| AutoCompleteModel results = await _client.ProcessStreamAsync( | ||
| new HttpSourceRequest(queryUri, logger), | ||
| async stream => |
There was a problem hiding this comment.
I don't know what the team code style is, if they link lamdas defined ahead of the method call or within it.
Nigusu-Allehu
force-pushed
the
dev-nyenework-autocomplete-stj
branch
from
01dc4d3 to
6f4e797
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Related: NuGet/Home#14846
Description
PR Checklist