Change "Up for grabs" to "good first issue" in ReadMe#10395
Merged
joelverhagen merged 2 commits intoNuGet:devfrom Apr 5, 2025
Merged
Change "Up for grabs" to "good first issue" in ReadMe#10395joelverhagen merged 2 commits intoNuGet:devfrom
joelverhagen merged 2 commits intoNuGet:devfrom
Conversation
[ReleasePrep][2025.03.25]RI of dev into main
I noticed, that the "up for grabs" label was removed and the best fit seems to be "good first issue".
advay26
reviewed
Apr 2, 2025
Member
advay26
left a comment
advay26
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for noticing this and following through with the change!
Can you please change the PR target branch to dev. We usually merge into that first.
advay26
approved these changes
Apr 3, 2025
Member
|
Thanks @robertmuehsig, nice to see you as always 🙂 |
JPGrieb
pushed a commit
to JPGrieb/NuGetGallery
that referenced
this pull request
Jun 19, 2025
I noticed, that the "up for grabs" label was removed and the best fit seems to be "good first issue". Co-authored-by: Maria Ghiondea <11394867+mariaghiondea@users.noreply.github.com>
joelverhagen
added a commit
that referenced
this pull request
Aug 11, 2025
* Add computed observables for deprecation reasons Updated `page-manage-deprecation.js` to include new computed observables: `chosenItemsHasUndeprecatedVersion` and `chosenItemsHasDeprecatedVersion`. Introduced observable properties for `isLegacy`, `hasCriticalBugs`, and `isOther` to track deprecation reasons. Modified `_ManageDeprecation.cshtml` to display alerts based on these properties and ensure proper binding for checkbox inputs. * Fixed white space issues. * Fixed typos. * Remove trailing CR/LF from files. * Add computed observables for deprecation reasons Updated `page-manage-deprecation.js` to include new computed observables: `chosenItemsHasUndeprecatedVersion` and `chosenItemsHasDeprecatedVersion`. Introduced observable properties for `isLegacy`, `hasCriticalBugs`, and `isOther` to track deprecation reasons. Modified `_ManageDeprecation.cshtml` to display alerts based on these properties and ensure proper binding for checkbox inputs. * Update sign.thirdparty.props for ApiKeyV5 change (#10373) * Fix guardian false positive (#10399) * Fix * Fix2 * Final changes * Update RemovedPackages.md * [HotFix] Temporary limit to ascii only (#10409) Temporary allow ascii only * [HotFix]: Fix double encoding (#10417) * [HotFix]: Fix base address and blob uri decoding mismatch (#10429) * BUG: 10341 - Proper Display of License Information (#10383) * BUG: 10341 - Proper Display of License Information - Added `IsLicense` and `IsException` methods to improve license checking. - Introduced `MakeExceptionLink` and `MakePlainSpan` helpers .- Updated rendering logic for license links using new methods. * Undo whitespace --------- Co-authored-by: Joel Verhagen <jver@microsoft.com> * Exclude the source repo as dependent repo (#10347) * Cache top 6 popluar repos to exclude the repo itself if any * Add ComparableGitHubRepository to DisplayPackageViewModel * Compare Repos Id with ComparableGitHubRepository * Apply code suggestions * Fix total and top counts when excluding --------- Co-authored-by: Ruijie Shi <ruishi@microsoft.com> Co-authored-by: Joel Verhagen <jver@microsoft.com> * Disabling TRACE method functional tests (#10391) * Setup for running functional tests locally. * Printing URL * Not testing TRACE requests. * Change "Up for grabs" to "good first issue" (#10395) I noticed, that the "up for grabs" label was removed and the best fit seems to be "good first issue". Co-authored-by: Maria Ghiondea <11394867+mariaghiondea@users.noreply.github.com> * Do not call GetProperties on a blob when metadata is available via enumeration (#10400) * updating script render format to include Nonce * continued work with csp implementation * removed unwanted lines and update webconfig value * Update src/NuGetGallery/App_Code/ViewHelpers.cshtml Co-authored-by: lyndaidaii <64443925+lyndaidaii@users.noreply.github.com> * PR related changes * removed unwanted whitespaces * additional changes not included earlier * updated from obsolete crypto API use, added nonce to cookie compliance script * Make CSP header readable and remove whitespaces * more whitespace undoing * PR changes. Also included file hashes * Update src/NuGetGallery/Web.config Co-authored-by: lyndaidaii <64443925+lyndaidaii@users.noreply.github.com> * Remove spackage upload submit dropdown (#10393) * Change profile section aria label (#10384) * change API key edit button text (#10379) * Add learn more link to Framework legend (#10389) * [OIDC 17] Add token API for trading bearer token for API key (#10308) * [OIDC] Add token API for trading bearer token for API key * Add hard enable/disable switch for the token api controller * Use camelCase like our other JSON APIs * Make localhost certificate longer listed, warn about machine reboot (#10413) * Add support for markdown > alerts via markdig (#10173) Add support for markdown > alerts via markdig * Reduce database calls for Microsoft profile page from 21.056 to 2 (#10411) * Adding .NET 10 support to TFM search (#10408) * Temporary change * Changes * Undoind some changes * Undoing more changes * Undoing changes pt 3 * Log the Azure search request-id to help future debugging (#10419) Help debug https://github.com/NuGet/Engineering/issues/5075 * Handle 404 exceptions in StatusAggregator (#10430) * [Hotfix] Fix broken unit test blocking hotifx (#10434) * Revert "Reduce database calls for Microsoft profile page from 21.056 to 2 (#10411)" (#10433) This reverts commit 24d69cd. * Reduce database calls for Microsoft profile page from 21.056 to 42 (#10443) * Add copilot instructions for Visual Studio (#10394) * Upgrade Microsoft.Identity.Web to 3.8.2 (#10420) * Compile styles for changes made in upload.less file. (#10444) * update IP package version (#10446) * Fixed white space issues. * Fixed typos. * Remove trailing CR/LF from files. * Restored HTML that was accidentally removed. * Added helper function to eliminate duplicate code. * Resolve Conflict with Twitter / X anchor * Resolve indentation conflict * Resolve indentation conflict * Copied lines directly from dev branch to fix conflct * Add form control that was accidentally removed. Removed duplicate info messages that were added as a result of the managing merge conflicts. * Fixed twitter/x conflict * Fixed spacing again * Trying to resolve conflict * One more try. * One more try * Revert unrelated changes from merge * Reword since versions are selected --------- Co-authored-by: Joel Verhagen <jver@microsoft.com> Co-authored-by: Lanaparezanin <58230697+Lanaparezanin@users.noreply.github.com> Co-authored-by: v-sulagnapal <165667801+v-sulagnapal@users.noreply.github.com> Co-authored-by: Erick Yondon <8766776+erdembayar@users.noreply.github.com> Co-authored-by: ericstone93 <151231344+ericstone93@users.noreply.github.com> Co-authored-by: Ruijie Shi <ruishi@microsoft.com> Co-authored-by: Andrei Grigorev <angrigor@microsoft.com> Co-authored-by: Robert Muehsig <robert.muehsig@codeinside.eu> Co-authored-by: Maria Ghiondea <11394867+mariaghiondea@users.noreply.github.com> Co-authored-by: Miracle Aduku <56966553+enema17484@users.noreply.github.com> Co-authored-by: lyndaidaii <64443925+lyndaidaii@users.noreply.github.com> Co-authored-by: Lili Xie <v-xielili@microsoft.com> Co-authored-by: Daniel Cazzulino <daniel@cazzulino.com> Co-authored-by: Erik Ejlskov Jensen <ErikEJ@users.noreply.github.com> Co-authored-by: Advay Tandon <82980589+advay26@users.noreply.github.com> Co-authored-by: Tony Q. <tonyqus@gmail.com> Co-authored-by: Ryu Yu <11051729+ryuyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed, that the "up for grabs" label was removed and the best fit seems to be "good first issue".
Summary of the changes (in less than 80 characters):
Just changed the ReadMe.md to point to a valid label.
(No issue created)