docs(drivers): refresh guide on adding a db driver in docker#26038
Merged
rusackas merged 4 commits intoapache:masterfrom Nov 29, 2023
Merged
docs(drivers): refresh guide on adding a db driver in docker#26038rusackas merged 4 commits intoapache:masterfrom
rusackas merged 4 commits intoapache:masterfrom
Conversation
john-bodley
reviewed
Nov 21, 2023
rusackas
reviewed
Nov 29, 2023
rusackas
approved these changes
Nov 29, 2023
Member
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
These look like great improvements, and I think the whole page makes more sens overall now.
Member
|
BTW while this is up, I noticed that our "lean" docker has stuff like Druid, Hive, and both Postgres and MySQL. Actually "lean" also has this development file reqs: https://github.com/apache/superset/blob/master/requirements/development.in Arguably, I'd say we'd layer a "raw" layer without any drivers, a "lean" with Postgres only and the rest of drivers needed for tests/CI would be brought into the "ci" (top) layer. Maybe eventually a "fat" one with all supported drivers? |
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
I went in to fix a couple of broken links reported in BugHerd. While there, I refreshed the whole page, since it had been a while. I didn't remove much, just extraneous text. I did add a bit about debugging, including
docker exec -it.ADDITIONAL INFORMATION
Fixes BugHerd 110, noting that the files linked to (requirements.txt and requirements-dev.txt) no longer exist.