Merged
Conversation
sfirke
approved these changes
Jan 16, 2024
Member
sfirke
left a comment
sfirke
left a comment
There was a problem hiding this comment.
Looks great! Thanks for these fixes. And nice catch on the wrong formatting on that setup.py link and the other broken link.
Member
|
Thanks @fenilgmehta for a great clean contribution! The way you shared screenshots and examples in the PR was very helpful 🙏 |
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix link to
docker_build_push.shindocs/docs/installation/installing-superset-from-scratch.mdxFix syntax of link to
setup.pyfile indocs/docs/installation/installing-superset-from-scratch.mdxFix links in multiple doc pages so that they take us to the locally hosted URL when we run the docs using the below commands
cd docs npm run startTESTING INSTRUCTIONS
Start local version of docs using the below commands
cd docs npm run startVisit http://localhost:3000/docs/installation/installing-superset-from-scratch
Before the fix -
setup.pywas shown as plain textAfter the fix -
setup.pyis highlighted as a linkClicking on
this filelink on the same page should take us to a valid file on the GitHub.Clicking on
Configuring Supersetshould take us to http://localhost:3001/docs/installation/configuring-superset instead of https://superset.apache.org/docs/installation/configuring-superset/ . We can test other pages in the same way.