豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

chore: Deprecates the DASHBOARD_CROSS_FILTERS feature flag#26633

Merged
michael-s-molina merged 2 commits intoapache:masterfrom
michael-s-molina:deprecate-cross-filters-ff
Jan 17, 2024
Merged

chore: Deprecates the DASHBOARD_CROSS_FILTERS feature flag#26633
michael-s-molina merged 2 commits intoapache:masterfrom
michael-s-molina:deprecate-cross-filters-ff

Conversation

@michael-s-molina
Copy link
Copy Markdown
Member

SUMMARY

As part of the 4.0 approved initiatives, this PR deprecates the DASHBOARD_CROSS_FILTERS feature flag which is currently True by default. The feature is already being used in production environments and we believe it's not something admins would want to disable.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested review from a team and rusackas January 16, 2024 16:04
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jan 16, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5b62d8) 68.98% compared to head (f304755) 66.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26633      +/-   ##
==========================================
- Coverage   68.98%   66.85%   -2.13%     
==========================================
  Files        1930     1930              
  Lines       75309    75309              
  Branches     8429     8429              
==========================================
- Hits        51949    50345    -1604     
- Misses      21213    22817    +1604     
  Partials     2147     2147              
Flag Coverage Δ
javascript 56.48% <ø> (ø)
mysql 77.89% <ø> (ø)
postgres 77.99% <ø> (ø)
presto ?
python 78.12% <ø> (-4.45%) ⬇️
sqlite 77.57% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the rebase.

@michael-s-molina michael-s-molina merged commit eff4422 into apache:master Jan 17, 2024
Muhammed-baban pushed a commit to intellica-tech/reporting-tool that referenced this pull request Jan 19, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 First shipped in 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🚢 4.0.0 First shipped in 4.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants