豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

fix: Revert "buld(deps): bump swagger-ui-react from 4.1.3 to 5.11.0 in docs (#26552)#26679

Merged
michael-s-molina merged 1 commit intoapache:masterfrom
michael-s-molina:revert-7884df1ee2
Jan 19, 2024
Merged

fix: Revert "buld(deps): bump swagger-ui-react from 4.1.3 to 5.11.0 in docs (#26552)#26679
michael-s-molina merged 1 commit intoapache:masterfrom
michael-s-molina:revert-7884df1ee2

Conversation

@michael-s-molina
Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina commented Jan 19, 2024

SUMMARY

#26552 bumped swagger-ui-react from 4.1.3 to 5.11.0. As a side effect, the react-redux dependency in yarn.lock was also upgraded from 7.1.20 to 9.0.4 which requires React 18. Given that the docs project uses React 17, it produced the following error:

Attempted import error: 'useSyncExternalStore' is not exported from 'react' (imported as 'React2').

Another side effect of the upgrade was:

Module not found: Error: Can't resolve 'url' in '/home/runner/work/superset/superset/docs/
node_modules/@saucelabs/theme-github-codeblock/build/theme/ReferenceCodeBlock'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
Error:  Client bundle compiled with errors therefore further build is impossible.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "url": require.resolve("url/") }'
	- install 'url'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "url": false }

This PR reverts the change.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested review from a team and rusackas January 19, 2024 14:55
@rusackas
Copy link
Copy Markdown
Member

Now it seems we can't even rever this thing because there was a less-than-ideal version of prismjs - maybe we can bump that.

@michael-s-molina michael-s-molina merged commit 649ff4d into apache:master Jan 19, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants