豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

chore: add google-auth for new example dashboard#26816

Merged
rusackas merged 1 commit intomasterfrom
deps-for-dashboard
Jan 26, 2024
Merged

chore: add google-auth for new example dashboard#26816
rusackas merged 1 commit intomasterfrom
deps-for-dashboard

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

SUMMARY

Add the google-auth (via shillelagh[gsheetsapi]) so that we can have Evan's fancy dashboard (#26442) as an example in new Superset installs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding!

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f084572) 67.22% compared to head (fbf339c) 67.22%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26816      +/-   ##
==========================================
- Coverage   67.22%   67.22%   -0.01%     
==========================================
  Files        1894     1894              
  Lines       74192    74192              
  Branches     8244     8244              
==========================================
- Hits        49878    49877       -1     
- Misses      22242    22243       +1     
  Partials     2072     2072              
Flag Coverage Δ
mysql 77.96% <ø> (+0.02%) ⬆️
postgres 78.06% <ø> (ø)
python 78.19% <ø> (-0.01%) ⬇️
sqlite 77.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas merged commit c657745 into master Jan 26, 2024
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
@rusackas rusackas deleted the deps-for-dashboard branch April 16, 2024 16:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 First shipped in 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 4.0.0 First shipped in 4.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants