fix: correct operator precedence in pack_ue8m0_to_int assertion#310
Open
kuishou68 wants to merge 1 commit intodeepseek-ai:mainfrom
Open
fix: correct operator precedence in pack_ue8m0_to_int assertion#310kuishou68 wants to merge 1 commit intodeepseek-ai:mainfrom
kuishou68 wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
Problem
In
deep_gemm/utils/math.py, thepack_ue8m0_to_intfunction has an operator precedence bug in its assertion:In Python, the
==operator has higher precedence than&. So this is actually parsed as:((1 << 23) - 1) == 0evaluates toFalse(i.e.,0), sox.view(torch.int) & 0produces a tensor of all zeros..all()on all zeros returnsTrue.The assertion always passes, never catching cases where mantissa bits are non-zero.
Fix
Added parentheses to ensure
&is applied before==:This correctly verifies that the lower 23 mantissa bits are all zero, which is required for valid UE8M0 format floats.