豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Add GroupDependencySelector integration to CreateGroupUpdatePullRequest#12968

Merged
robaiken merged 1 commit intomainfrom
robaiken/GroupDependencySelector-in-create_group_update_pull_request
Aug 29, 2025
Merged

Add GroupDependencySelector integration to CreateGroupUpdatePullRequest#12968
robaiken merged 1 commit intomainfrom
robaiken/GroupDependencySelector-in-create_group_update_pull_request

Conversation

@robaiken
Copy link
Copy Markdown
Contributor

What's this PR doing?

This PR integrates GroupDependencySelector with CreateGroupUpdatePullRequest to fix the "superset problem" where group PRs were including dependencies outside the group's scope. The integration adds filtering after compilation to ensure group PRs only contain dependencies that belong to the group.

Anything worth calling out?

The filtering is implemented in the dependency_change method and gated behind the :group_membership_enforcement feature flag for backward compatibility. I tested the integration by mocking compile_all_dependency_changes_for to verify the correct workflow level.

How do we know it works?

All 5 new tests pass, confirming that filtering works when enabled and is bypassed when disabled. Existing functionality remains intact (68/68 operation tests pass), so group PRs will now correctly include only dependencies that match the group's criteria.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@robaiken robaiken self-assigned this Aug 28, 2025
@robaiken robaiken force-pushed the robaiken/GroupDependencySelector-in-create_group_update_pull_request branch from d24302f to 8900fce Compare August 28, 2025 15:32
@robaiken robaiken marked this pull request as ready for review August 28, 2025 15:37
@robaiken robaiken requested a review from a team as a code owner August 28, 2025 15:37
@robaiken robaiken force-pushed the robaiken/GroupDependencySelector-in-create_group_update_pull_request branch from 8900fce to 8b8ff64 Compare August 29, 2025 10:38
@robaiken robaiken merged commit d07617e into main Aug 29, 2025
152 of 153 checks passed
@robaiken robaiken deleted the robaiken/GroupDependencySelector-in-create_group_update_pull_request branch August 29, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants