豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Autocorrectable rubocop-sorbet fixes for future version#13029

Merged
JamieMagee merged 1 commit intomainfrom
jamiemagee/rubocop-sorbet
Sep 11, 2025
Merged

Autocorrectable rubocop-sorbet fixes for future version#13029
JamieMagee merged 1 commit intomainfrom
jamiemagee/rubocop-sorbet

Conversation

@JamieMagee
Copy link
Copy Markdown
Member

What are you trying to accomplish?

We're quite a few versions behind on rubocop-sorbet1. We're using 0.8.7 and the latest release is 0.10.1. There are quite a few changes to the cops between those two versions. This PR makes the auto-correctable changes in preparation for the actual upgrade.

Supersedes #12732

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Footnotes

  1. https://github.com/Shopify/rubocop-sorbet/releases

@JamieMagee JamieMagee requested a review from a team as a code owner September 5, 2025 17:32
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: swift Swift packages L: python:uv L: helm labels Sep 5, 2025
jpinz
jpinz previously approved these changes Sep 5, 2025
@JamieMagee
Copy link
Copy Markdown
Member Author

I won't be fixing the "Sorbet / Sorbet Typing Mode Check" failure, as these are autogenerated fixed that touch many files, and it would require me to manually add Sorbet types to dozens of files.

@JamieMagee JamieMagee force-pushed the jamiemagee/rubocop-sorbet branch from 30f8477 to 1c9cbf4 Compare September 11, 2025 16:32
@JamieMagee JamieMagee merged commit 8002497 into main Sep 11, 2025
182 of 185 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/rubocop-sorbet branch September 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: dart:pub Dart packages via pub L: docker Docker containers L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: helm L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python:uv L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants