Autocorrectable rubocop-sorbet fixes for future version#13029
Merged
JamieMagee merged 1 commit intomainfrom Sep 11, 2025
Merged
Autocorrectable rubocop-sorbet fixes for future version#13029JamieMagee merged 1 commit intomainfrom
rubocop-sorbet fixes for future version#13029JamieMagee merged 1 commit intomainfrom
Conversation
jpinz
previously approved these changes
Sep 5, 2025
6f4563c to
891eb06
Compare
891eb06 to
30f8477
Compare
jpinz
approved these changes
Sep 9, 2025
Member
Author
|
I won't be fixing the "Sorbet / Sorbet Typing Mode Check" failure, as these are autogenerated fixed that touch many files, and it would require me to manually add Sorbet types to dozens of files. |
30f8477 to
1c9cbf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We're quite a few versions behind on
rubocop-sorbet1. We're using0.8.7and the latest release is0.10.1. There are quite a few changes to the cops between those two versions. This PR makes the auto-correctable changes in preparation for the actual upgrade.Supersedes #12732
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist
Footnotes
https://github.com/Shopify/rubocop-sorbet/releases ↩