豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Remove remaining Sorbet TODOs#13065

Merged
JamieMagee merged 1 commit intomainfrom
jamiemagee/sorbet-todo
Sep 12, 2025
Merged

Remove remaining Sorbet TODOs#13065
JamieMagee merged 1 commit intomainfrom
jamiemagee/sorbet-todo

Conversation

@JamieMagee
Copy link
Copy Markdown
Member

What are you trying to accomplish?

This required adding the http gem to the root Gemfile to that bundle exec tapioca gem generated the required .rbi files

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@JamieMagee JamieMagee requested a review from a team as a code owner September 12, 2025 16:20
@JamieMagee JamieMagee changed the title Remove unnecessary RuboCop merge statements Remove remaining Sorbet TODOs Sep 12, 2025
@JamieMagee JamieMagee force-pushed the jamiemagee/sorbet-todo branch from a54fe19 to 27bcb2a Compare September 12, 2025 17:54
@JamieMagee JamieMagee merged commit addf975 into main Sep 12, 2025
71 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/sorbet-todo branch September 12, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants