Merged
Conversation
JamieMagee
force-pushed
the
jamiemagee/improve-sorbet-shims
branch
from
5488e5d to
2593bb8
Compare
sebasgomez238
previously approved these changes
Sep 18, 2025
JamieMagee
force-pushed
the
jamiemagee/improve-sorbet-shims
branch
2 times, most recently
from
c6565ff to
15ecf27
Compare
…texts The GHES test contexts were failing because the :record_update_job_unknown_error experiment state was bleeding through from previous cloud tests. This adds proper before/after blocks to explicitly disable the experiment in GHES contexts and reset the experiment state properly.
JamieMagee
force-pushed
the
jamiemagee/improve-sorbet-shims
branch
from
f2c2758 to
6dc9876
Compare
sebasgomez238
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We added these shims along the way as we were learning how to adopt Sorbet, to quickly unblock ourselves. Since then we know a lot more, and can improve (or remove) some of these shims.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist