豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

fix group rebases not working#13168

Merged
jakecoffman merged 4 commits intomainfrom
fix-group-updates
Sep 24, 2025
Merged

fix group rebases not working#13168
jakecoffman merged 4 commits intomainfrom
fix-group-updates

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

@jakecoffman jakecoffman commented Sep 24, 2025

What are you trying to accomplish?

This is like the fix in #13161, but for groups. I missed them initially thinking we didn't add PR numbers to the group payload but we did.

I'm going to open an issue to centralize all of these checks in the PullRequest class to help avoid this in the future.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

I'll try rebasing #13146 which is also stuck.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman marked this pull request as ready for review September 24, 2025 13:56
@jakecoffman jakecoffman requested a review from a team as a code owner September 24, 2025 13:56
@jakecoffman
Copy link
Copy Markdown
Member Author

Verified it fixed group rebases: #13146

@jakecoffman jakecoffman merged commit 86f7cc5 into main Sep 24, 2025
210 of 212 checks passed
@jakecoffman jakecoffman deleted the fix-group-updates branch September 24, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants