allow for and display extra message with private_source_bad_response#13364
Merged
allow for and display extra message with private_source_bad_response#13364
private_source_bad_response#13364Conversation
sebasgomez238
approved these changes
Oct 22, 2025
brettfo
force-pushed
the
dev/brettfo/nuget-error-extra-info
branch
from
1e658eb to
e22cb77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many reasons a response to a NuGet query could eventually get turned into
private_source_bad_responsebut that information isn't conveyed to the log which makes determining what actually went wrong very difficult.This PR adds a
Messageproperty to that object. The official API doesn't allow for this extra field so it has to be excluded from the official error serialization and reporting but it is added to the log so a manual review can report the exact error that occurred.JobErrorBase.csis where the extra info is elevated to thisMessageproperty andMessageReportTests.csshows that it will appear in the log. The rest of the changes are to verify thisMessageproperty is appropriately populated and/or aren't relevant for the given test but need to be present to make it build.