Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the nix Docker build stage to use a patched nix base image version, aligning the nix ecosystem container with the desired security baseline.
Changes:
- Bump
docker.io/nixos/niximage tag from2.34.1to2.34.5in the nix Dockerfile.
Show a summary per file
| File | Description |
|---|---|
nix/Dockerfile |
Updates the nix base image tag used to source /nix for the final updater image. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
jonabc
approved these changes
Apr 8, 2026
We run nix in single-user mode, not multi-user mode, so I don't believe this vulnerbaility affects us. However, it should prevent any spurious reports GHSA-g3g9-5vj6-r3gj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Bump the nix Docker image from 2.34.1 to 2.34.5, which patches CVE-2026-39860 — a critical (9.0) sandbox escape where a symlink in a fixed-output derivation could let a builder overwrite arbitrary files as root.
We run nix in single-user mode, so I don't believe we're actually affected (the exploit targets the multi-user daemon). Bumping anyway to prevent spurious vulnerability reports.
GHSA-g3g9-5vj6-r3gj
Anything you want to highlight for special attention from reviewers?
One-line change in Dockerfile: the base image tag goes from
2.34.1to2.34.5. No functional changes.How will you know you've accomplished your goal?
The nix ecosystem's existing tests pass, and the built image uses nix 2.34.5.
Checklist