豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Add logging for NuGetRestorer#3027

Merged
natidea merged 1 commit intodotnet:masterfrom
natidea:nominateLogging
Dec 7, 2017
Merged

Add logging for NuGetRestorer#3027
natidea merged 1 commit intodotnet:masterfrom
natidea:nominateLogging

Conversation

@natidea
Copy link
Copy Markdown
Contributor

@natidea natidea commented Dec 6, 2017

Add logging for NuGetRestorer to capture information sent to NuGet during nomination

Customer scenario

To assist investigations of problems in interactions between project-system and NuGet, add logging to specify what information is sent. Users can turn on logging with existing set PROJECTSYSTEM_PROJECTOUTPUTPANEENABLED=1 flag

Risk and Performance impact

None, only active when debugging flag is on

/cc @dotnet/project-system

@Pilchie
Copy link
Copy Markdown
Member

Pilchie commented Dec 7, 2017

BTW - What determines if this log is enabled? Is there a way for customers to collect our logs when things go wrong?

@davkean
Copy link
Copy Markdown
Member

davkean commented Dec 7, 2017

Enabled by default in DEBUG builds, otherwise, a new category shows up in the Output window when environment is set PROJECTSYSTEM_PROJECTOUTPUTPANEENABLED=1

@natidea natidea merged commit 6d0159e into dotnet:master Dec 7, 2017
@natidea natidea deleted the nominateLogging branch December 7, 2017 22:19
@nkolev92
Copy link
Copy Markdown
Contributor

nkolev92 commented Dec 7, 2017

This is amazing.
Thanks @natidea
//cc @rrelyea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants