pipeline: remove redundant Paths from Settings and Supporter#49841
pipeline: remove redundant Paths from Settings and Supporter#49841orestisfl wants to merge 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
ce06766 to
6b92ca0
Compare
6b92ca0 to
cd05c9f
Compare
cd05c9f to
cc35ae1
Compare
The Pipeline already has beatInfo which contains Paths. Remove the separate paths field from Pipeline and Settings, and remove the paths parameter from the processing.Supporter.Create interface. The builder now uses info.Paths directly when calling SetPaths on processors.
cc35ae1 to
b662742
Compare
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughThis change removes the ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
TL;DRAll 5 failed Buildkite jobs are caused by the same compile error: Remediation
Investigation detailsRoot Cause
Nearby code in the same file consistently uses Evidence
Key log excerpts: Verification
Follow-upAfter the one-line fix, all five failures should clear together since they are the same compile break surfacing in multiple pipelines. Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Proposed commit message
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry in./changelog/fragmentsusing the changelog tool.Disruptive User Impact
None. Internal API change only.
How to test this PR locally
Related issues
Beat.Info#49803