ref(commits): Remove "Unable to Fetch Commits" email#113445
Open
ref(commits): Remove "Unable to Fetch Commits" email#113445
Conversation
Delete the "Unable to Fetch Commits" email templates, debug view, fixture, and the task code that sent it on fetch failures. The colocated identity-invalid email stays but its subject is now hardcoded to "Action Required", so the commit_failure flag and its template branch are dead code and have been removed as well. Also drops the now-unused get_emails_for_user_or_org helper and the release param on fetch_commits_for_ref_with_lifecycle. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
| ) | ||
| emails = get_emails_for_user_or_org(user, release.organization_id) | ||
| msg.send_async(to=emails) | ||
| lifecycle.record_failure(e) |
Member
There was a problem hiding this comment.
does this capture a Sentry event, or some metric at least?
we need to monitor this somehow
Member
Author
There was a problem hiding this comment.
@bruno-garcia lifecycle.record_failure(e) will emit a metric and create a sentry error, so nothing is dropped. The other path with record_halt(e) just does the metric, which is also sufficient 👍
cmanallen
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retires the "unable to fetch commits" email and locks the identity email's subject to "action required".