豆豆友情提示:这是一个非官方 GitHub 代理镜像,主要用于网络测试或访问加速。请勿在此进行登录、注册或处理任何敏感信息。进行这些操作请务必访问官方网站 github.com。 Raw 内容也通过此代理提供。
Skip to content

Fix for #14 - Buffer events always and check buffer always after socket polling#20

Open
holgerk wants to merge 3 commits intojakubkulhan:masterfrom
holgerk:master
Open

Fix for #14 - Buffer events always and check buffer always after socket polling#20
holgerk wants to merge 3 commits intojakubkulhan:masterfrom
holgerk:master

Conversation

@holgerk
Copy link
Copy Markdown

@holgerk holgerk commented Jun 22, 2019

No description provided.

@jakubkulhan
Copy link
Copy Markdown
Owner

Hi. Thank you for the PR! And sorry for such a delay :( I've looked through the code and it looks good, I've run current test suite and it passes. Could you add a regression test case, i.e. test that fails with the old version and gets fixed by this patch?

@holgerk
Copy link
Copy Markdown
Author

holgerk commented Jul 3, 2019

Hi, you can checkout 96a5d5b to see the failing test for the DevtoolsClient.

A problem that i see with the current solution, is that the buffer is not flushed.
I think we could flush the buffer when a command is executed from stack level 0.
Commands issued from callbacks (stack level > 0) should not flush the buffer, because of possible awaiters from lower levels.
What do you think?

@oscx
Copy link
Copy Markdown

oscx commented Mar 19, 2020

@jakubkulhan can the pull request be confirmed or any conflict from manual review pending?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants