Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
Resubmission of #4381 to introduce a client-side, multi-bucket rate limiter for GitHub API requests, allowing different RPC classes to be throttled independently based on server-provided quota bucket headers.
Changes:
- Added support for the
x-github-quota-bucket-nameresponse header and introduced endpoint→bucket learning. - Reworked throttling to be per quota-bucket (shared across endpoints) and removed the background cleanup timer in favor of explicit window cleanup.
- Adjusted lifecycle management (removed interval-based disposals; updated service dispose behavior and internal maps).
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Pull request overview
Resubmission of #4381 that updates GithubApiFetcherService to support multi-bucket, client-side rate limiting based on server-provided quota bucket headers, aligning throttling behavior with per-RPC quotas.
Changes:
- Add support for
x-github-quota-bucket-nameand learn per-endpoint quota buckets from responses. - Replace periodic sliding-window cleanup with explicit cleanup on throttle decisions and add a “slow start” ramp-up.
- Refactor throttler lifecycle management (remove interval/dispose behavior; keep throttlers in maps keyed by bucket).
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
TylerLeonhardt
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting #4381 with merge conflicts fixed since I can't push to the original branch