Fix 'Hide Ghost Requests' not filtering ghost prompt groups#4425
Merged
Fix 'Hide Ghost Requests' not filtering ghost prompt groups#4425
Conversation
The ghost request filter in the Chat Debug Log only checked ChatRequestItem instances but not ChatPromptItem (parent grouping nodes). This meant ghost prompt groups labeled 'Ghost' or 'Ghost | ...' remained visible even with the filter active. Extend isGhostRequest to also handle ChatPromptItem, matching the pattern already used for NES request filtering. Fixes microsoft/vscode#297566
ulugbekna
force-pushed
the
ulugbekna/passive-amphibian
branch
from
af3fb64 to
cc92109
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the "Hide Ghost Requests" filter in the Chat Debug Log by extending isGhostRequest to also handle ChatPromptItem (parent grouping nodes), matching the pattern already used by isNesRequest.
Changes:
- Added ghost request check for
ChatPromptItemin theitemIncludedmethod - Extended
isGhostRequestto accept bothChatPromptItemandChatRequestItem, consistent withisNesRequest
bpasero
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ghost request filter in the Chat Debug Log only checked `ChatRequestItem` instances but not `ChatPromptItem` (parent grouping nodes). This meant ghost prompt groups labeled "Ghost" or "Ghost | ..." remained visible even with the filter active.
Extends `isGhostRequest` to also handle `ChatPromptItem`, matching the pattern already used for NES request filtering.
Fixes microsoft/vscode#297566