Allow specifying custom BYOK known model list#4438
Open
dolfies wants to merge 4 commits intomicrosoft:mainfrom
Open
Allow specifying custom BYOK known model list#4438dolfies wants to merge 4 commits intomicrosoft:mainfrom
dolfies wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a user-configurable setting to override the BYOK “known models” JSON endpoint (previously hardcoded to a VS Code CDN URL), enabling custom model lists (e.g., via a gist) to be used by BYOK providers.
Changes:
- Introduces a new configuration key for the BYOK model info URL with a default pointing to the existing CDN JSON.
- Updates BYOK provider registration flow to fetch the known model list from the configured URL.
- Exposes the new setting in
package.jsonand localizes its description inpackage.nls.json.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/platform/configuration/common/configurationService.ts | Adds ConfigKey.BYOKModelInfoUrl configuration key with a default CDN URL. |
| src/extension/byok/vscode-node/byokContribution.ts | Reads the configured URL and uses it when fetching the BYOK known model list. |
| package.nls.json | Adds localized description string for the new setting. |
| package.json | Contributes github.copilot.chat.byok.modelInfoUrl to the extension’s settings. |
Author
|
Are there any blockers on a review here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the list of models supported by BYOK is hosted at a hardcoded URL on the VSCode CDN. This makes contributing to or configuring the list of models quite difficult.
This PR adds a simple option to allow users to point the list to a URL of their choosing (e.g. a gist), for customizability and aiding development.